beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Work logged] (BEAM-4038) Support Kafka Headers in KafkaIO
Date Tue, 17 Apr 2018 17:22:00 GMT

     [ https://issues.apache.org/jira/browse/BEAM-4038?focusedWorklogId=91842&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-91842
]

ASF GitHub Bot logged work on BEAM-4038:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 17/Apr/18 17:21
            Start Date: 17/Apr/18 17:21
    Worklog Time Spent: 10m 
      Work Description: rangadi commented on a change in pull request #5111: [BEAM-4038] Support
Kafka Headers in KafkaIO
URL: https://github.com/apache/beam/pull/5111#discussion_r182158860
 
 

 ##########
 File path: sdks/java/io/kafka/src/main/java/org/apache/beam/sdk/io/kafka/KafkaRecordCoder.java
 ##########
 @@ -66,9 +76,24 @@ public void encode(KafkaRecord<K, V> value, OutputStream outStream)
throws IOExc
         longCoder.decode(inStream),
         longCoder.decode(inStream),
         KafkaTimestampType.forOrdinal(intCoder.decode(inStream)),
+        getHeaders(headerCoder.decode(inStream)),
 
 Review comment:
   Same here, set headers to null in case of empty iterable (again in order to handle old
versions properly).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 91842)
    Time Spent: 3h 20m  (was: 3h 10m)

> Support Kafka Headers in KafkaIO
> --------------------------------
>
>                 Key: BEAM-4038
>                 URL: https://issues.apache.org/jira/browse/BEAM-4038
>             Project: Beam
>          Issue Type: New Feature
>          Components: io-java-kafka
>            Reporter: Geet Kumar
>            Assignee: Raghu Angadi
>            Priority: Minor
>          Time Spent: 3h 20m
>  Remaining Estimate: 0h
>
> Headers have been added to Kafka Consumer/Producer records (KAFKA-4208). The purpose
of this JIRA is to support this feature in KafkaIO.  
>  



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message