beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Ismaël Mejía (JIRA) <j...@apache.org>
Subject [jira] [Comment Edited] (BEAM-4016) Direct runner incorrect lifecycle, @SplitRestriction should execute after @Setup on SplittableDoFn
Date Thu, 12 Apr 2018 09:46:00 GMT

    [ https://issues.apache.org/jira/browse/BEAM-4016?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16435262#comment-16435262
] 

Ismaël Mejía edited comment on BEAM-4016 at 4/12/18 9:45 AM:
-------------------------------------------------------------

Since it seems you are back [~jkff] can you confirm if this is the desired order so I can
open the corresponding issues for Flink and Dataflow too.


was (Author: iemejia):
Since it seems you are back [~jkff] can you confirm if this is the desired order so I can
open the corresponding issues for Spark and Dataflow too.

> Direct runner incorrect lifecycle, @SplitRestriction should execute after @Setup on SplittableDoFn
> --------------------------------------------------------------------------------------------------
>
>                 Key: BEAM-4016
>                 URL: https://issues.apache.org/jira/browse/BEAM-4016
>             Project: Beam
>          Issue Type: Bug
>          Components: runner-direct
>    Affects Versions: 2.4.0
>            Reporter: Ismaël Mejía
>            Assignee: Thomas Groh
>            Priority: Major
>         Attachments: sdf-splitrestriction-lifeycle-test.patch
>
>
> The method annotated with @SplitRestriction is the method where we can define the RestrictionTrackers
(splits) in advance in a SDF. It makes sense to execute this after the @Setup method given
that usually connections are established at Setup and can be used to ask the different data
stores about the partitioning strategy. I added a test for this in the SplittableDoFnTest.SDFWithLifecycle
test.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message