beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Work logged] (BEAM-3995) Launch Nexmark suites from gradle and update web page docs
Date Wed, 11 Apr 2018 13:52:00 GMT

     [ https://issues.apache.org/jira/browse/BEAM-3995?focusedWorklogId=89962&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-89962
]

ASF GitHub Bot logged work on BEAM-3995:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 11/Apr/18 13:51
            Start Date: 11/Apr/18 13:51
    Worklog Time Spent: 10m 
      Work Description: lukecwik commented on a change in pull request #5051: [BEAM-3995]
Add basic Gradle run task to Nexmark
URL: https://github.com/apache/beam/pull/5051#discussion_r180760912
 
 

 ##########
 File path: sdks/java/nexmark/build.gradle
 ##########
 @@ -43,8 +68,53 @@ dependencies {
   shadow project(path: ":beam-runners-direct-java", configuration: "shadow")
   shadow library.java.slf4j_jdk14
   testCompile library.java.hamcrest_core
+
+  gradleRun project(path: project.path, configuration: "shadow")
+  gradleRun project(path: nexmarkRunnerDependency, configuration: "shadow")
+
+  // The Spark runner requires the user to provide a Spark dependency. For self-contained
+  // runs with the Spark runner, we can provide such a dependency. This is deliberately phrased
+  // to not hardcode any runner other than :runners:direct-java
+  if (shouldProvideSpark) {
+    gradleRun library.java.spark_streaming
+    gradleRun library.java.spark_core, {
+      exclude group:"org.slf4j", module:"jul-to-slf4j"
+    }
+
+    // TODO: pre-Gradle this was excluded in the SparkRunner overall, in Gradle it is
+    // only excluded in the testRuntimeClasspath.
+    gradleRun project(path: ":beam-sdks-java-core", configuration: "shadow"), {
 
 Review comment:
   You don't need to specify the project, you can just exclude the values configuration wide.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 89962)
    Time Spent: 4h 50m  (was: 4h 40m)

> Launch Nexmark suites from gradle and update web page docs
> ----------------------------------------------------------
>
>                 Key: BEAM-3995
>                 URL: https://issues.apache.org/jira/browse/BEAM-3995
>             Project: Beam
>          Issue Type: Sub-task
>          Components: examples-nexmark, website
>            Reporter: Kenneth Knowles
>            Assignee: Kenneth Knowles
>            Priority: Major
>          Time Spent: 4h 50m
>  Remaining Estimate: 0h
>
> Currently our instructions for running Nexmark benchmarks on various runners is pretty
tightly tied to Maven. We need a good story for running them with gradle (or just building
an executable with gradle and running that standalone).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message