beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Work logged] (BEAM-3973) Allow to disable batch API in SpannerIO
Date Wed, 04 Apr 2018 14:34:00 GMT

     [ https://issues.apache.org/jira/browse/BEAM-3973?focusedWorklogId=87563&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-87563
]

ASF GitHub Bot logged work on BEAM-3973:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 04/Apr/18 14:33
            Start Date: 04/Apr/18 14:33
    Worklog Time Spent: 10m 
      Work Description: iemejia commented on a change in pull request #4946: [BEAM-3973] Adds
a parameter to the Cloud Spanner read connector that can disable batch API
URL: https://github.com/apache/beam/pull/4946#discussion_r179143055
 
 

 ##########
 File path: sdks/java/io/google-cloud-platform/src/test/java/org/apache/beam/sdk/io/gcp/spanner/SpannerReadIT.java
 ##########
 @@ -193,6 +196,52 @@ public void testQuery() throws Exception {
     p.run();
   }
 
+  @Test
+  public void testReadAll() throws Exception {
+    DatabaseClient databaseClient =
 
 Review comment:
   We can make the data creation code into a method, since every test is reusing exactly the
same code, and refactor this in the other tests too.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 87563)
    Time Spent: 1h  (was: 50m)

> Allow to disable batch API in SpannerIO
> ---------------------------------------
>
>                 Key: BEAM-3973
>                 URL: https://issues.apache.org/jira/browse/BEAM-3973
>             Project: Beam
>          Issue Type: Bug
>          Components: io-java-gcp
>    Affects Versions: 2.4.0
>            Reporter: Mairbek Khadikov
>            Assignee: Mairbek Khadikov
>            Priority: Major
>             Fix For: 2.5.0
>
>          Time Spent: 1h
>  Remaining Estimate: 0h
>
> In 2.4.0, SpannerIO#read has been migrated to use batch API. The batch API provides abstractions
to scale out reads from Spanner, but it requires the query to be root-partitionable. The root-partitionable
queries cover majority of the use cases, however there are examples when running arbitrary
query is useful. For example, reading all the table names from the information_schema.* and
reading the content of those tables in the next step. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message