beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Work logged] (BEAM-3437) Support schema in PCollections
Date Wed, 04 Apr 2018 18:18:00 GMT

     [ https://issues.apache.org/jira/browse/BEAM-3437?focusedWorklogId=87701&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-87701
]

ASF GitHub Bot logged work on BEAM-3437:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 04/Apr/18 18:17
            Start Date: 04/Apr/18 18:17
    Worklog Time Spent: 10m 
      Work Description: reuvenlax commented on a change in pull request #4964: [BEAM-3437]
Introduce Schema class, and use it in BeamSQL
URL: https://github.com/apache/beam/pull/4964#discussion_r179236211
 
 

 ##########
 File path: sdks/java/extensions/sql/src/test/java/org/apache/beam/sdk/extensions/sql/impl/parser/BeamSqlParserTest.java
 ##########
 @@ -163,13 +164,13 @@ private static Table mockTable(String name, String type, String comment,
JSONObj
         .columns(ImmutableList.of(
             Column.builder()
                 .name("id")
-                .coder(INTEGER)
+                .typeDescriptor(TypeName.INT32.type())
                 .primaryKey(false)
                 .comment("id")
                 .build(),
             Column.builder()
                 .name("name")
-                .coder(VARCHAR)
+                .typeDescriptor(CalciteUtils.toFieldType(SqlTypeName.VARCHAR))
 
 Review comment:
   <!--thread_id:cc_179026015_t; commit:9fe3a6d29a348e46ff2f5ca9e4396bf667e28046; resolved:0-->
   <!--section:context-quote-->
   > **akedin** wrote:
   > I don't think that CalciteUtils should be used here, even if it's temporary. I'd rather
have our own `SqlType.VARCHAR = TypeName.STRING.withMetadata("VARCHAR")`.
   
   <!--section:body-->
   Done. Added it to RowSqlTypes (so we can later remove the builder class there, but leave
the defined types.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 87701)
    Time Spent: 7h 20m  (was: 7h 10m)

> Support schema in PCollections
> ------------------------------
>
>                 Key: BEAM-3437
>                 URL: https://issues.apache.org/jira/browse/BEAM-3437
>             Project: Beam
>          Issue Type: Wish
>          Components: beam-model
>            Reporter: Jean-Baptiste Onofré
>            Assignee: Jean-Baptiste Onofré
>            Priority: Major
>          Time Spent: 7h 20m
>  Remaining Estimate: 0h
>
> As discussed with some people in the team, it would be great to add schema support in
{{PCollections}}. It will allow us:
> 1. To expect some data type in {{PTransforms}}
> 2. Improve some runners with additional features (I'm thinking about Spark runner with
data frames for instance).
> A technical draft document has been created: 
> https://docs.google.com/document/d/1tnG2DPHZYbsomvihIpXruUmQ12pHGK0QIvXS1FOTgRc/edit?disco=AAAABhykQIs&ts=5a203b46&usp=comment_email_document
> I also started a PoC on a branch, I will update this Jira with a "discussion" PR.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message