beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Work logged] (BEAM-3355) Make Go SDK runtime harness hooks pluggable
Date Thu, 05 Apr 2018 22:10:00 GMT

     [ https://issues.apache.org/jira/browse/BEAM-3355?focusedWorklogId=88251&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-88251
]

ASF GitHub Bot logged work on BEAM-3355:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 05/Apr/18 22:09
            Start Date: 05/Apr/18 22:09
    Worklog Time Spent: 10m 
      Work Description: wcn3 commented on a change in pull request #4311: [BEAM-3355] Diagnostic
interfaces
URL: https://github.com/apache/beam/pull/4311#discussion_r179614779
 
 

 ##########
 File path: sdks/go/pkg/beam/core/runtime/harness/session.go
 ##########
 @@ -213,3 +186,59 @@ func recordFooter() error {
 		},
 	})
 }
+
+// CaptureHook writes the messaging content consumed and
+// produced by the worker, allowing the data to be used as
+// an input for the session runner. Since workers can exist
+// in a variety of environments, this allows the runner
+// to tailor the behavior best for its particular needs.
+type CaptureHook io.WriteCloser
+
+// CaptureHookFactory produces a CaptureHook from the supplied
+// options.
+type CaptureHookFactory func([]string) CaptureHook
+
+var captureHookRegistry = make(map[string]CaptureHookFactory)
+var enabledCaptureHook string
+
+func init() {
+	hf := func(opts []string) hooks.Hook {
+		return hooks.Hook{
+			Init: func(_ context.Context) error {
 
 Review comment:
   The hooks are invoked inside the harness package via the entry points 'recordInstructionRequest'
and 'recordInstructionResponse' that apply a serialization format and then invoke the registered
hooks.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 88251)
    Time Spent: 5h 50m  (was: 5h 40m)

> Make Go SDK runtime harness hooks pluggable
> -------------------------------------------
>
>                 Key: BEAM-3355
>                 URL: https://issues.apache.org/jira/browse/BEAM-3355
>             Project: Beam
>          Issue Type: Improvement
>          Components: sdk-go
>            Reporter: Henning Rohde
>            Assignee: Bill Neubauer
>            Priority: Minor
>          Time Spent: 5h 50m
>  Remaining Estimate: 0h
>
> We currently hardcode cpu profiling and session recording in the harness. We should make
it pluggable instead.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message