From commits-return-60950-archive-asf-public=cust-asf.ponee.io@beam.apache.org Wed Mar 14 02:16:04 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 4EF1418064F for ; Wed, 14 Mar 2018 02:16:04 +0100 (CET) Received: (qmail 79368 invoked by uid 500); 14 Mar 2018 01:16:03 -0000 Mailing-List: contact commits-help@beam.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@beam.apache.org Delivered-To: mailing list commits@beam.apache.org Received: (qmail 79359 invoked by uid 99); 14 Mar 2018 01:16:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 14 Mar 2018 01:16:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id EE219C1168 for ; Wed, 14 Mar 2018 01:16:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.511 X-Spam-Level: X-Spam-Status: No, score=-109.511 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id a-Ue2Rdcc3LJ for ; Wed, 14 Mar 2018 01:16:02 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id E483B5F238 for ; Wed, 14 Mar 2018 01:16:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 2C8FFE0110 for ; Wed, 14 Mar 2018 01:16:01 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 35ABA2148B for ; Wed, 14 Mar 2018 01:16:00 +0000 (UTC) Date: Wed, 14 Mar 2018 01:16:00 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: commits@beam.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Work logged] (BEAM-3847) Remove the rich wrapper from EnvironmentManager MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/BEAM-3847?focusedWorklogId=3D8= 0165&page=3Dcom.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpane= l#worklog-80165 ] ASF GitHub Bot logged work on BEAM-3847: ---------------------------------------- Author: ASF GitHub Bot Created on: 14/Mar/18 01:15 Start Date: 14/Mar/18 01:15 Worklog Time Spent: 10m=20 Work Description: tgroh opened a new pull request #4866: [BEAM-3847] = Use InstructionRequestHandler in RemoteEnvironment URL: https://github.com/apache/beam/pull/4866 =20 =20 This separates the need to construct the rich client, instead allowing callers to wrap with their own rich wrapper as appropriate. =20 ------------------------ =20 Follow this checklist to help us incorporate your contribution quickly a= nd easily: =20 - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/= projects/BEAM/issues/) filed for the change (usually before you start worki= ng on it). Trivial changes like typos do not require a JIRA issue. Your p= ull request should address just this issue, without pulling in other change= s. - [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in Appro= ximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA is= sue. - [ ] Write a pull request description that is detailed enough to under= stand: - [ ] What the pull request does - [ ] Why it does it - [ ] How it does it - [ ] Why this approach - [ ] Each commit in the pull request should have a meaningful subject = line and body. - [ ] Run `mvn clean verify` to make sure basic checks pass. A more tho= rough check will be performed on your pull request automatically. - [ ] If this contribution is large, please file an Apache [Individual = Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). =20 =20 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. =20 For queries about this service, please contact Infrastructure at: users@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 80165) Time Spent: 10m Remaining Estimate: 0h > Remove the rich wrapper from EnvironmentManager > ----------------------------------------------- > > Key: BEAM-3847 > URL: https://issues.apache.org/jira/browse/BEAM-3847 > Project: Beam > Issue Type: Bug > Components: runner-core > Reporter: Thomas Groh > Assignee: Thomas Groh > Priority: Major > Labels: portability > Time Spent: 10m > Remaining Estimate: 0h > > The current wrapper couples the rich implementation of the Control Plane = instead of wrapping the simplest possible wrapper. Using the simple=C2=A0cl= ient is preferable, as it permits more sophisticated users to enrich the cl= ient directly, and the additional complexity required for other users is al= most nonexistent (it consists of one additional call, with access to a Data= Service, and can be wrapped around an EnvironmentManager wrapper) -- This message was sent by Atlassian JIRA (v7.6.3#76005)