From commits-return-60807-archive-asf-public=cust-asf.ponee.io@beam.apache.org Tue Mar 13 01:08:05 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 9F26C18072F for ; Tue, 13 Mar 2018 01:08:04 +0100 (CET) Received: (qmail 42216 invoked by uid 500); 13 Mar 2018 00:08:03 -0000 Mailing-List: contact commits-help@beam.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@beam.apache.org Delivered-To: mailing list commits@beam.apache.org Received: (qmail 42207 invoked by uid 99); 13 Mar 2018 00:08:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 13 Mar 2018 00:08:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 0E388C03E7 for ; Tue, 13 Mar 2018 00:08:03 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -109.511 X-Spam-Level: X-Spam-Status: No, score=-109.511 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id lwPDJUnEyGad for ; Tue, 13 Mar 2018 00:08:02 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 9EADD5F476 for ; Tue, 13 Mar 2018 00:08:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id B30CAE0217 for ; Tue, 13 Mar 2018 00:08:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 5B24021474 for ; Tue, 13 Mar 2018 00:08:00 +0000 (UTC) Date: Tue, 13 Mar 2018 00:08:00 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: commits@beam.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Work logged] (BEAM-3841) Python TestDataflowRunner should oeverride run_pipeline MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/BEAM-3841?focusedWorklogId=79668&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-79668 ] ASF GitHub Bot logged work on BEAM-3841: ---------------------------------------- Author: ASF GitHub Bot Created on: 13/Mar/18 00:07 Start Date: 13/Mar/18 00:07 Worklog Time Spent: 10m Work Description: markflyhigh commented on issue #4856: [BEAM-3841] Fix TestDataflowRunner.run to run_pipeline URL: https://github.com/apache/beam/pull/4856#issuecomment-372502819 +R: @robertwb ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 79668) Time Spent: 20m (was: 10m) > Python TestDataflowRunner should oeverride run_pipeline > ------------------------------------------------------- > > Key: BEAM-3841 > URL: https://issues.apache.org/jira/browse/BEAM-3841 > Project: Beam > Issue Type: Bug > Components: testing > Reporter: Mark Liu > Assignee: Mark Liu > Priority: Major > Time Spent: 20m > Remaining Estimate: 0h > > [TestDataflowRunner|https://github.com/apache/beam/blob/master/sdks/python/apache_beam/runners/dataflow/test_dataflow_runner.py] is inherited from [DataflowRunner|https://github.com/apache/beam/blob/master/sdks/python/apache_beam/runners/dataflow/dataflow_runner.py]. Basically, it wraps DataflowRunner.run_pipeline and provide more test actions. > However DataflowRunner.run renamed to run_pipeline in [this commit|https://github.com/apache/beam/commit/8cf222d3db1188aff5432af548961fc670f97635], but run function in TestDataflowRunner didn't change. > We should change it accordingly. -- This message was sent by Atlassian JIRA (v7.6.3#76005)