From commits-return-60350-archive-asf-public=cust-asf.ponee.io@beam.apache.org Fri Mar 9 17:50:05 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 43581180676 for ; Fri, 9 Mar 2018 17:50:05 +0100 (CET) Received: (qmail 68923 invoked by uid 500); 9 Mar 2018 16:50:04 -0000 Mailing-List: contact commits-help@beam.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@beam.apache.org Delivered-To: mailing list commits@beam.apache.org Received: (qmail 68914 invoked by uid 99); 9 Mar 2018 16:50:04 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 09 Mar 2018 16:50:04 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id C80711A0852 for ; Fri, 9 Mar 2018 16:50:03 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -101.511 X-Spam-Level: X-Spam-Status: No, score=-101.511 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id nTRBuuO-X3WQ for ; Fri, 9 Mar 2018 16:50:02 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id 489E75FBE5 for ; Fri, 9 Mar 2018 16:50:02 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 03BACE0970 for ; Fri, 9 Mar 2018 16:50:01 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 535A221441 for ; Fri, 9 Mar 2018 16:50:00 +0000 (UTC) Date: Fri, 9 Mar 2018 16:50:00 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: commits@beam.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Work logged] (BEAM-3803) [Nexmark] Not all runners support attempted metrics MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/BEAM-3803?focusedWorklogId=78942&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-78942 ] ASF GitHub Bot logged work on BEAM-3803: ---------------------------------------- Author: ASF GitHub Bot Created on: 09/Mar/18 16:49 Start Date: 09/Mar/18 16:49 Worklog Time Spent: 10m Work Description: apilloud commented on a change in pull request #4823: [BEAM-3803] [Nexmark] Handle both committed and attempted metrics URL: https://github.com/apache/beam/pull/4823#discussion_r173504875 ########## File path: sdks/java/core/src/main/java/org/apache/beam/sdk/metrics/MetricResult.java ########## @@ -32,14 +33,13 @@ /** * Return the value of this metric across all successfully completed parts of the pipeline. - * - *

Not all runners will support committed metrics. If they are not supported, the runner will - * throw an {@link UnsupportedOperationException}. */ + @Nullable Review comment: Both the direct runner and dataflow runner use autovalue to implement this class and return null rather then throwing an exception. It seems changing those implementations to match the documentation has a bigger potential to break users then changing the documentation to match the implementation. Are there other implementations I missed? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org Issue Time Tracking ------------------- Worklog Id: (was: 78942) Time Spent: 2.5h (was: 2h 20m) > [Nexmark] Not all runners support attempted metrics > --------------------------------------------------- > > Key: BEAM-3803 > URL: https://issues.apache.org/jira/browse/BEAM-3803 > Project: Beam > Issue Type: Bug > Components: runner-dataflow > Reporter: Andrew Pilloud > Assignee: Andrew Pilloud > Priority: Major > Labels: nexmark > Time Spent: 2.5h > Remaining Estimate: 0h > > The dataflow runner only supports committed metrics for batch jobs and attempted metrics for streaming jobs. Nexmark should use the best available metric source. -- This message was sent by Atlassian JIRA (v7.6.3#76005)