From commits-return-60068-archive-asf-public=cust-asf.ponee.io@beam.apache.org Wed Mar 7 01:55:05 2018 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx-eu-01.ponee.io (Postfix) with SMTP id 3E502180652 for ; Wed, 7 Mar 2018 01:55:05 +0100 (CET) Received: (qmail 97011 invoked by uid 500); 7 Mar 2018 00:55:04 -0000 Mailing-List: contact commits-help@beam.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@beam.apache.org Delivered-To: mailing list commits@beam.apache.org Received: (qmail 97002 invoked by uid 99); 7 Mar 2018 00:55:04 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 07 Mar 2018 00:55:04 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 9561AC0111 for ; Wed, 7 Mar 2018 00:55:03 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -110.311 X-Spam-Level: X-Spam-Status: No, score=-110.311 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id zBqewd9rJnR2 for ; Wed, 7 Mar 2018 00:55:02 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id C76705F4AE for ; Wed, 7 Mar 2018 00:55:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id C394BE030D for ; Wed, 7 Mar 2018 00:55:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 24D1B253FF for ; Wed, 7 Mar 2018 00:55:00 +0000 (UTC) Date: Wed, 7 Mar 2018 00:55:00 +0000 (UTC) From: "Ben Sidhom (JIRA)" To: commits@beam.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Created] (BEAM-3793) SDK harness should log bad gRPC responses MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 Ben Sidhom created BEAM-3793: -------------------------------- Summary: SDK harness should log bad gRPC responses Key: BEAM-3793 URL: https://issues.apache.org/jira/browse/BEAM-3793 Project: Beam Issue Type: Bug Components: sdk-go Reporter: Ben Sidhom Assignee: Henning Rohde As of now, if a null ProvisionInfo is passed to the boot code, it panics wh= en trying to convert to JSON. It should at the very least log a useful erro= r message if a bad ProvisionInfo is received. =C2=A0 Sample stack trace: panic: reflect: call of reflect.Value.Field on zero Value goroutine 1 [running]: reflect.Value.Field(0x0, 0x0, 0x0, 0x0, 0x0, 0x1, 0x81f2e0) /Users/sidhom/.gradle/go/binary/1.9/go/src/reflect/value.go:759 +0x12e github.com/apache/beam/sdks/java/boot/vendor/github.com/golang/protobuf/jso= npb.(*Marshaler).marshalObject(0xc42015cb10, 0xc4201bbbb0, 0xb7a7e0, 0x0, 0= x0, 0x0, 0x0, 0x0, 0xc4201bbbd0, 0x410e58) /Users/sidhom/Downloads/git/beam/sdks/java/container/.gogradle/project_gop= ath/src/github.com/apache/beam/sdks/java/boot/vendor/github.com/golang/prot= obuf/jsonpb/jsonpb.go:207 +0x1040 github.com/apache/beam/sdks/java/boot/vendor/github.com/golang/protobuf/jso= npb.(*Marshaler).Marshal(0xc42015cb10, 0xb70ae0, 0xc4201ac770, 0xb7a7e0, 0x= 0, 0x8a53e0, 0x4c3601) /Users/sidhom/Downloads/git/beam/sdks/java/container/.gogradle/project_gop= ath/src/github.com/apache/beam/sdks/java/boot/vendor/github.com/golang/prot= obuf/jsonpb/jsonpb.go:122 +0xc1 github.com/apache/beam/sdks/java/boot/vendor/github.com/golang/protobuf/jso= npb.(*Marshaler).MarshalToString(0xc42015cb10, 0xb7a7e0, 0x0, 0x1, 0x15, 0x= 0, 0x0) /Users/sidhom/Downloads/git/beam/sdks/java/container/.gogradle/project_gop= ath/src/github.com/apache/beam/sdks/java/boot/vendor/github.com/golang/prot= obuf/jsonpb/jsonpb.go:128 +0x6e github.com/apache/beam/sdks/java/boot/vendor/github.com/apache/beam/sdks/go= /pkg/beam/provision.ProtoToJSON(0x0, 0x12, 0xc4201bbdc0, 0x1, 0x1) /Users/sidhom/Downloads/git/beam/sdks/java/container/.gogradle/project_gop= ath/src/github.com/apache/beam/sdks/java/boot/vendor/github.com/apache/beam= /sdks/go/pkg/beam/provision/provison.go:79 +0x51 main.main() /Users/sidhom/Downloads/git/beam/sdks/java/container/.gogradle/project_gop= ath/src/github.com/apache/beam/sdks/java/boot/boot.go:80 +0x309 -- This message was sent by Atlassian JIRA (v7.6.3#76005)