beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Work logged] (BEAM-3951) Update SDK container images and instructions to use Gradle
Date Tue, 27 Mar 2018 22:38:00 GMT

     [ https://issues.apache.org/jira/browse/BEAM-3951?focusedWorklogId=85052&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-85052
]

ASF GitHub Bot logged work on BEAM-3951:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 27/Mar/18 22:37
            Start Date: 27/Mar/18 22:37
    Worklog Time Spent: 10m 
      Work Description: lukecwik commented on a change in pull request #4958: [BEAM-3951]
Migrate container instructions and builds to Gradle
URL: https://github.com/apache/beam/pull/4958#discussion_r177592928
 
 

 ##########
 File path: sdks/go/container/build.gradle
 ##########
 @@ -46,13 +46,7 @@ golang {
 }
 
 docker {
-  String repositoryRoot
-  if (rootProject.hasProperty(["docker-repository-root"])) {
-    repositoryRoot = rootProject["docker-repository-root"]
-  } else {
-    repositoryRoot = "${System.properties["user.name"]}-docker-apache.bintray.io/beam"
-  }
-  name "${repositoryRoot}/go:latest"
+  name containerImageName("go")
   files "./build/"
 
 Review comment:
   Note that with this setup we are building the boot binary multiple times, once per container.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

            Worklog Id:     (was: 85052)
            Time Spent: 10m
    Remaining Estimate: 0h

> Update SDK container images and instructions to use Gradle
> ----------------------------------------------------------
>
>                 Key: BEAM-3951
>                 URL: https://issues.apache.org/jira/browse/BEAM-3951
>             Project: Beam
>          Issue Type: Sub-task
>          Components: build-system
>            Reporter: Henning Rohde
>            Assignee: Henning Rohde
>            Priority: Major
>              Labels: portability
>          Time Spent: 10m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message