[ https://issues.apache.org/jira/browse/BEAM-3882?focusedWorklogId=82311&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-82311
]
ASF GitHub Bot logged work on BEAM-3882:
----------------------------------------
Author: ASF GitHub Bot
Created on: 20/Mar/18 16:28
Start Date: 20/Mar/18 16:28
Worklog Time Spent: 10m
Work Description: tgroh commented on issue #4900: [BEAM-3882] Fix StateRequestHandler
interface to be idiomatic
URL: https://github.com/apache/beam/pull/4900#issuecomment-374664047
retest this please
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 82311)
Time Spent: 40m (was: 0.5h)
> Make StateRequestHandler::accept interface idiomatic.
> -----------------------------------------------------
>
> Key: BEAM-3882
> URL: https://issues.apache.org/jira/browse/BEAM-3882
> Project: Beam
> Issue Type: Improvement
> Components: runner-core
> Reporter: Axel Magnuson
> Assignee: Axel Magnuson
> Priority: Minor
> Time Spent: 40m
> Remaining Estimate: 0h
>
> StateRequestHandler was based on some Dataflow SDK source code that does not conform
to Beam coding conventions. In particular, the accept method takes its return value as a
parameter, which is a code smell.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
|