beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Work logged] (BEAM-3882) Make StateRequestHandler::accept interface idiomatic.
Date Mon, 19 Mar 2018 23:40:00 GMT

     [ https://issues.apache.org/jira/browse/BEAM-3882?focusedWorklogId=82093&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-82093
]

ASF GitHub Bot logged work on BEAM-3882:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 19/Mar/18 23:39
            Start Date: 19/Mar/18 23:39
    Worklog Time Spent: 10m 
      Work Description: tgroh commented on a change in pull request #4900: [BEAM-3882] Fix
StateRequestHandler interface to be idiomatic
URL: https://github.com/apache/beam/pull/4900#discussion_r175616304
 
 

 ##########
 File path: runners/java-fn-execution/src/main/java/org/apache/beam/runners/fnexecution/state/StateRequestHandler.java
 ##########
 @@ -34,7 +34,6 @@
    * <p>Throwing an error during handling will complete the handler result {@link CompletionStage}
    * exceptionally.
    */
-  void accept(
-      BeamFnApi.StateRequest request, CompletionStage<BeamFnApi.StateResponse.Builder>
result)
+  CompletionStage<BeamFnApi.StateResponse.Builder> accept(BeamFnApi.StateRequest request)
 
 Review comment:
   s/accept/handle

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 82093)
    Time Spent: 20m  (was: 10m)

> Make StateRequestHandler::accept interface idiomatic.
> -----------------------------------------------------
>
>                 Key: BEAM-3882
>                 URL: https://issues.apache.org/jira/browse/BEAM-3882
>             Project: Beam
>          Issue Type: Improvement
>          Components: runner-core
>            Reporter: Axel Magnuson
>            Assignee: Axel Magnuson
>            Priority: Minor
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> StateRequestHandler was based on some Dataflow SDK source code that does not conform
to Beam coding conventions.  In particular, the accept method takes its return value as a
parameter, which is a code smell.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message