beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Work logged] (BEAM-3865) Incorrect timestamp on merging window outputs.
Date Mon, 19 Mar 2018 19:51:00 GMT

     [ https://issues.apache.org/jira/browse/BEAM-3865?focusedWorklogId=81991&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-81991
]

ASF GitHub Bot logged work on BEAM-3865:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 19/Mar/18 19:50
            Start Date: 19/Mar/18 19:50
    Worklog Time Spent: 10m 
      Work Description: charlesccychen commented on a change in pull request #4879: [BEAM-3865]
Fix watermark hold handling bug.
URL: https://github.com/apache/beam/pull/4879#discussion_r175563315
 
 

 ##########
 File path: sdks/python/apache_beam/transforms/trigger_test.py
 ##########
 @@ -81,16 +84,8 @@ def bundle_data(data, size):
 
     if not groupings:
       groupings = [1]
+    grouping = list(groupings) + [-group_by for group_by in groupings]
 
 Review comment:
   <!--thread_id:cc_175236867_t; commit:23bbd5d9bf76313060d10b6a040be8c452229d64; resolved:1-->
   <!--section:context-quote-->
   > **robertwb** wrote:
   > Oh, yes, nice eye!
   > 
   > And fixing this makes some of the non-deterministic ones fail... Enabling only explicitly
on some tests.
   
   <!--section:body-->
   Thanks!  Could you also add a comment at the beginning of this method on the behavior of
`groupings`?  It is not obvious without a close reading.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 81991)
    Time Spent: 1.5h  (was: 1h 20m)

> Incorrect timestamp on merging window outputs.
> ----------------------------------------------
>
>                 Key: BEAM-3865
>                 URL: https://issues.apache.org/jira/browse/BEAM-3865
>             Project: Beam
>          Issue Type: Bug
>          Components: sdk-py-core
>    Affects Versions: 2.2.0, 2.3.0
>            Reporter: Robert Bradshaw
>            Assignee: Ahmet Altay
>            Priority: Major
>          Time Spent: 1.5h
>  Remaining Estimate: 0h
>
> Looks like we're setting multiple watermark holds with one arbitrarily being held. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message