beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Work logged] (BEAM-3855) Add Go SDK support for protobuf coder
Date Wed, 21 Mar 2018 21:43:00 GMT

     [ https://issues.apache.org/jira/browse/BEAM-3855?focusedWorklogId=82940&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-82940
]

ASF GitHub Bot logged work on BEAM-3855:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 21/Mar/18 21:42
            Start Date: 21/Mar/18 21:42
    Worklog Time Spent: 10m 
      Work Description: wcn3 commented on issue #4908: BEAM-3855: Add Protocol Buffer support
URL: https://github.com/apache/beam/pull/4908#issuecomment-375105611
 
 
   I'm not following the points in the "On a similar vein" paragraph.
   
   If a Go struct has a proto message as a field, the resulting struct is still concrete and
serializable. Unfortunately, it'd devolve to encoding the proto using the JSON coder based
on the top-level type. This is unfortunate, but it would work. I'm not sure it needs to be
disallowed. I see how having the coder registry would alleviate this situation: the top-level
struct would be JSON encoded, but the proto message member would be looked up and use the
proto encoding for that "subtree"
   
   I'm confused by the phrase "non-concrete codeable types." Of the non-concrete types, we
have Containers, which are serialized based on its underlying Concrete type, Universals which
aren't actually serialized, and Composites, which are a custom encoding based on the underlying
types. What did you mean by this phrase?
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 82940)
    Time Spent: 50m  (was: 40m)

> Add Go SDK support for protobuf coder
> -------------------------------------
>
>                 Key: BEAM-3855
>                 URL: https://issues.apache.org/jira/browse/BEAM-3855
>             Project: Beam
>          Issue Type: Improvement
>          Components: sdk-go
>            Reporter: Willy Lulciuc
>            Assignee: Bill Neubauer
>            Priority: Major
>          Time Spent: 50m
>  Remaining Estimate: 0h
>
> This JIRA is for something functional. We might want to use the coder registry for a
more general solution, when implemented. 



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message