beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <>
Subject [jira] [Work logged] (BEAM-3803) Dataflow runner should handle metrics per the spec
Date Fri, 09 Mar 2018 19:35:00 GMT


ASF GitHub Bot logged work on BEAM-3803:

                Author: ASF GitHub Bot
            Created on: 09/Mar/18 19:34
            Start Date: 09/Mar/18 19:34
    Worklog Time Spent: 10m 
      Work Description: kennknowles commented on a change in pull request #4841: BEAM-3803:
Dataflow runner implements metrics contract

 File path: runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/
 @@ -350,10 +352,18 @@ public static MetricQueryResults create(
     public abstract MetricName name();
     public abstract String step();
-    public abstract T committed();
-    @Nullable
+    protected abstract T committedInternal();
     public abstract T attempted();
+    public T committed() {
+      T committed = committedInternal();
+      if (committed == null) {
+        throw new UnsupportedOperationException("This runner does not currently support committed"
 Review comment:
   I see - the javadoc tells you to do this. That sucks. Want to fix the javadoc to have this
better spec?

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:

Issue Time Tracking

    Worklog Id:     (was: 79000)
    Time Spent: 3h 40m  (was: 3.5h)

> Dataflow runner should handle metrics per the spec
> --------------------------------------------------
>                 Key: BEAM-3803
>                 URL:
>             Project: Beam
>          Issue Type: Bug
>          Components: runner-dataflow
>            Reporter: Andrew Pilloud
>            Assignee: Andrew Pilloud
>            Priority: Major
>              Labels: nexmark
>          Time Spent: 3h 40m
>  Remaining Estimate: 0h
> The dataflow runner only supports committed metrics for batch jobs and attempted metrics
for streaming jobs. It should always support attempted metrics and throw an UnsupportedOperationException
when the metrics are missing.

This message was sent by Atlassian JIRA

View raw message