beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <>
Subject [jira] [Work logged] (BEAM-3803) [Nexmark] Not all runners support attempted metrics
Date Fri, 09 Mar 2018 16:50:00 GMT


ASF GitHub Bot logged work on BEAM-3803:

                Author: ASF GitHub Bot
            Created on: 09/Mar/18 16:49
            Start Date: 09/Mar/18 16:49
    Worklog Time Spent: 10m 
      Work Description: apilloud commented on a change in pull request #4823: [BEAM-3803]
[Nexmark] Handle both committed and attempted metrics

 File path: sdks/java/core/src/main/java/org/apache/beam/sdk/metrics/
 @@ -32,14 +33,13 @@
    * Return the value of this metric across all successfully completed parts of the pipeline.
-   *
-   * <p>Not all runners will support committed metrics. If they are not supported,
the runner will
-   * throw an {@link UnsupportedOperationException}.
+  @Nullable
 Review comment:
   Both the direct runner and dataflow runner use autovalue to implement this class and return
null rather then throwing an exception. It seems changing those implementations to match the
documentation has a bigger potential to break users then changing the documentation to match
the implementation. Are there other implementations I missed?

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:

Issue Time Tracking

    Worklog Id:     (was: 78942)
    Time Spent: 2.5h  (was: 2h 20m)

> [Nexmark] Not all runners support attempted metrics
> ---------------------------------------------------
>                 Key: BEAM-3803
>                 URL:
>             Project: Beam
>          Issue Type: Bug
>          Components: runner-dataflow
>            Reporter: Andrew Pilloud
>            Assignee: Andrew Pilloud
>            Priority: Major
>              Labels: nexmark
>          Time Spent: 2.5h
>  Remaining Estimate: 0h
> The dataflow runner only supports committed metrics for batch jobs and attempted metrics
for streaming jobs. Nexmark should use the best available metric source.

This message was sent by Atlassian JIRA

View raw message