beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <>
Subject [jira] [Work logged] (BEAM-3789) [SQL] Support Nested Rows
Date Sat, 10 Mar 2018 20:30:00 GMT


ASF GitHub Bot logged work on BEAM-3789:

                Author: ASF GitHub Bot
            Created on: 10/Mar/18 20:29
            Start Date: 10/Mar/18 20:29
    Worklog Time Spent: 10m 
      Work Description: kennknowles commented on issue #4822: [BEAM-3789][SQL] Support nested
   <img class="emoji" title=":lgtm:" alt=":lgtm:" align="absmiddle" src=""
height="20" width="61"/>
   Reviewed 8 of 8 files at r1.
   Review status: all files reviewed at latest revision, 3 unresolved discussions.
line 44 at r1](
([raw file](*
   > ```Java
   >     .BeamSqlPlusExpression;
   > import org.apache.beam.sdk.extensions.sql.impl.interpreter.operator.comparison
   >     .BeamSqlEqualsExpression;
   > ```
   This is a bit weird
line 23 at r1](
([raw file](*
   > ```Java
   >  */
   > @DefaultAnnotation(NonNull.class)
   > package org.apache.beam.sdk.extensions.sql.impl.interpreter.operator.row;
   > ```
   I think we might be getting a bit extreme about nesting Java packages. I prefer to keep
them as un-nested as possible so that package-private access is useful and it is easy to browse
the whole system at a glance. Most tools are best at one directory at a time, up to a few
dozen files.
line 200 at r1](
([raw file](*
   > ```Java
   >             .apply(
   >                 BeamSql.query(
   >                     "SELECT `PCOLLECTION`.`f_nestedRow`.`f_nestedString` FROM PCOLLECTION"))
   > ```
   Now that there's also arrays, it would be nice to build some complex nesting and make sure
it all works. This PR is fine now, but you do have to rebase to resolve the conflicts anyhow.
   *Comments from [Reviewable](*
   <!-- Sent from -->

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:

Issue Time Tracking

    Worklog Id:     (was: 79253)
    Time Spent: 0.5h  (was: 20m)

> [SQL] Support Nested Rows
> -------------------------
>                 Key: BEAM-3789
>                 URL:
>             Project: Beam
>          Issue Type: Improvement
>          Components: dsl-sql
>            Reporter: Anton Kedin
>            Assignee: Anton Kedin
>            Priority: Major
>          Time Spent: 0.5h
>  Remaining Estimate: 0h
> Add support for SqlTypeName.ROW

This message was sent by Atlassian JIRA

View raw message