beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <>
Subject [jira] [Work logged] (BEAM-3738) Enable Py3 linting in Jenkins
Date Fri, 23 Mar 2018 18:36:00 GMT


ASF GitHub Bot logged work on BEAM-3738:

                Author: ASF GitHub Bot
            Created on: 23/Mar/18 18:35
            Start Date: 23/Mar/18 18:35
    Worklog Time Spent: 10m 
      Work Description: aaltay commented on a change in pull request #4877: [BEAM-3738] Enable
py3 lint and cleanup tox.ini.

 File path: sdks/python/tox.ini
 @@ -17,142 +17,107 @@
 # new environments will be excluded by default unless explicitly added to envlist.
-# TODO (after BEAM-3671) add lint_py3 back in.
-envlist = py27,py27gcp,py27cython,lint_py2,docs
+envlist = py27,py27-{gcp,cython2,lint},py3-lint,docs
 toxworkdir = {toxinidir}/target/.tox
 # Disable all errors and warnings except for the ones related to blank lines.
 # pylint does not check the number of blank lines.
 select = E3
+# Shared environment options.
+# Set [] options for pip installation of apache-beam tarball.
+extras = test
+# Don't warn that these commands aren't installed.
+whitelist_externals =
+  find
+  time
-# autocomplete_test depends on nose when invoked directly.
-deps =
-  nose==1.3.7
-  grpcio-tools==1.3.5
 commands =
   python --version
   pip --version
-  # Clean up all previous python generated files.
-  - find apache_beam -type f -name '*.pyc' -delete
-  pip install -e .[test]
+  {toxinidir}/
   python apache_beam/examples/complete/
   python test
-passenv = TRAVIS*
+  {toxinidir}/
+# This environment will fail in Jenkins if named "py27-cython".
 # cython tests are only expected to work in linux (2.x and 3.x)
 # If we want to add other platforms in the future, it should be:
 # `platform = linux2|darwin|...`
 # See for platform codes
 platform = linux2
-# autocomplete_test depends on nose when invoked directly.
 deps =
-  nose==1.3.7
-  grpcio-tools==1.3.5
-  cython==0.25.2
-  find
-  time
+  cython==0.26.1
 Review comment:
   That is fair to not change the version in this PR. We should consider upgrading it.
   It would be nice to have a single source of truth. Although I do not see how pip-compile
can update the Dockerfile. It is worth filing a JIRA for that.

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:

Issue Time Tracking

    Worklog Id:     (was: 83747)
    Time Spent: 11h 50m  (was: 11h 40m)

> Enable Py3 linting in Jenkins
> -----------------------------
>                 Key: BEAM-3738
>                 URL:
>             Project: Beam
>          Issue Type: Bug
>          Components: sdk-py-core, testing
>            Reporter: holdenk
>            Assignee: Ahmet Altay
>            Priority: Major
>          Time Spent: 11h 50m
>  Remaining Estimate: 0h
> After BEAM-3671 is finished enable linting.

This message was sent by Atlassian JIRA

View raw message