beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Work logged] (BEAM-3706) Update CombinePayload to improved model for Portability
Date Fri, 23 Mar 2018 20:12:00 GMT

     [ https://issues.apache.org/jira/browse/BEAM-3706?focusedWorklogId=83789&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-83789
]

ASF GitHub Bot logged work on BEAM-3706:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 23/Mar/18 20:11
            Start Date: 23/Mar/18 20:11
    Worklog Time Spent: 10m 
      Work Description: bsidhom commented on a change in pull request #4924: [BEAM-3706] Removing
side inputs from CombinePayload proto.
URL: https://github.com/apache/beam/pull/4924#discussion_r176851403
 
 

 ##########
 File path: runners/flink/src/main/java/org/apache/beam/runners/flink/FlinkStreamingTransformTranslators.java
 ##########
 @@ -912,12 +907,7 @@ public void translateNode(
       TypeInformation<WindowedValue<KV<K, OutputT>>> outputTypeInfo =
           context.getTypeInfo(context.getOutput(transform));
 
-      List<PCollectionView<?>> sideInputs;
-      try {
-        sideInputs = CombineTranslation.getSideInputs(context.getCurrentTransform());
-      } catch (IOException e) {
-        throw new RuntimeException(e);
-      }
+      List<PCollectionView<?>> sideInputs = new ArrayList<>();
 
 Review comment:
   As above, please remove references to side inputs here. If it's not clear how to do that,
please add a TODO and a new bug to track this removal.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 83789)
    Time Spent: 1h 10m  (was: 1h)

> Update CombinePayload to improved model for Portability
> -------------------------------------------------------
>
>                 Key: BEAM-3706
>                 URL: https://issues.apache.org/jira/browse/BEAM-3706
>             Project: Beam
>          Issue Type: Sub-task
>          Components: beam-model
>            Reporter: Daniel Oliveira
>            Assignee: Daniel Oliveira
>            Priority: Minor
>              Labels: portability
>          Time Spent: 1h 10m
>  Remaining Estimate: 0h
>
> This will mean changing the proto definition in beam_runner_api, most likely trimming
out fields that are no longer necessary and adding any new ones that could be useful. The
majority of work will probably be in investigating if some existing fields can actually be
removed (SideInputs and Parameters for example).



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message