beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Work logged] (BEAM-3702) Support system properties source for pipeline options
Date Fri, 16 Mar 2018 17:57:00 GMT

     [ https://issues.apache.org/jira/browse/BEAM-3702?focusedWorklogId=81284&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-81284
]

ASF GitHub Bot logged work on BEAM-3702:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 16/Mar/18 17:56
            Start Date: 16/Mar/18 17:56
    Worklog Time Spent: 10m 
      Work Description: lukecwik commented on a change in pull request #4683: [BEAM-3702]
adding fromJvm to create pipelineoptions from the system properties
URL: https://github.com/apache/beam/pull/4683#discussion_r175162404
 
 

 ##########
 File path: sdks/java/core/src/main/java/org/apache/beam/sdk/options/PipelineOptionsFactory.java
 ##########
 @@ -245,7 +263,19 @@ private Builder(String[] args, boolean validation,
      */
     public Builder fromArgs(String... args) {
       checkNotNull(args, "Arguments should not be null.");
-      return new Builder(args, validation, strictParsing, true);
+      options.add(current -> parseCommandLine(args, current.strictParsing));
 
 Review comment:
   It is important to point out that this is a subtle change in behavior. Before fromArgs
replaced the existing set of args and now we are accumulating them. Please update the javadoc
accordingly.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 81284)
    Time Spent: 8h 20m  (was: 8h 10m)

> Support system properties source for pipeline options
> -----------------------------------------------------
>
>                 Key: BEAM-3702
>                 URL: https://issues.apache.org/jira/browse/BEAM-3702
>             Project: Beam
>          Issue Type: Task
>          Components: sdk-java-core
>            Reporter: Romain Manni-Bucau
>            Assignee: Romain Manni-Bucau
>            Priority: Major
>             Fix For: 2.5.0
>
>          Time Spent: 8h 20m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message