From commits-return-58320-archive-asf-public=cust-asf.ponee.io@beam.apache.org Fri Feb 9 02:09:11 2018 Return-Path: X-Original-To: archive-asf-public@eu.ponee.io Delivered-To: archive-asf-public@eu.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by mx-eu-01.ponee.io (Postfix) with ESMTP id 915F818064F for ; Fri, 9 Feb 2018 02:09:11 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 80001160C5E; Fri, 9 Feb 2018 01:09:11 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id C8D51160C4A for ; Fri, 9 Feb 2018 02:09:10 +0100 (CET) Received: (qmail 25437 invoked by uid 500); 9 Feb 2018 01:09:09 -0000 Mailing-List: contact commits-help@beam.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@beam.apache.org Delivered-To: mailing list commits@beam.apache.org Received: (qmail 25427 invoked by uid 99); 9 Feb 2018 01:09:09 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 09 Feb 2018 01:09:09 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 834D21A07BD for ; Fri, 9 Feb 2018 01:09:09 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -101.511 X-Spam-Level: X-Spam-Status: No, score=-101.511 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id UR0irFVRYaOZ for ; Fri, 9 Feb 2018 01:09:07 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 622315F23E for ; Fri, 9 Feb 2018 01:09:07 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id EE5DEE00A3 for ; Fri, 9 Feb 2018 01:09:06 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id DD42721E83 for ; Fri, 9 Feb 2018 01:09:02 +0000 (UTC) Date: Fri, 9 Feb 2018 01:09:00 +0000 (UTC) From: =?utf-8?Q?Isma=C3=ABl_Mej=C3=ADa_=28JIRA=29?= To: commits@beam.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Assigned] (BEAM-3649) HadoopSeekableByteChannel breaks when backing InputStream doesn't supporte ByteBuffers MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/BEAM-3649?page=3Dcom.atlassian= .jira.plugin.system.issuetabpanels:all-tabpanel ] Isma=C3=ABl Mej=C3=ADa reassigned BEAM-3649: ---------------------------------- Assignee: (was: Reuven Lax) > HadoopSeekableByteChannel breaks when backing InputStream doesn't support= e ByteBuffers > -------------------------------------------------------------------------= ------------- > > Key: BEAM-3649 > URL: https://issues.apache.org/jira/browse/BEAM-3649 > Project: Beam > Issue Type: Bug > Components: sdk-java-extensions > Affects Versions: 2.0.0, 2.1.0, 2.2.0 > Reporter: Guillaume Balaine > Priority: Minor > > This happened last summer, when I wanted to use S3A as the backing HDFS a= ccess implementation.=C2=A0 > This is because while this method is called : [https://github.com/apache/= hadoop/blob/trunk/hadoop-common-project/hadoop-common/src/main/java/org/apa= che/hadoop/fs/FSDataInputStream.java#L145] > This class does not implement ByteBuffer readable https://github.com/apac= he/hadoop/blob/trunk/hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoo= p/fs/s3a/S3AFileSystem.java > I fixed it by manually incrementing the read position and copying the bac= king array instead of buffering. > [https://github.com/Igosuki/beam/commit/3838f0db43b6422833a045d1f097f6d76= 43219f1] > I know the s3 direct implementation is the preferred path,=C2=A0but this = is possible, and likely happens to a lot of developers. -- This message was sent by Atlassian JIRA (v7.6.3#76005)