beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Daniel Kulp (JIRA)" <>
Subject [jira] [Created] (BEAM-3640) Checkstyle enforcement of blank lines
Date Wed, 07 Feb 2018 19:09:01 GMT
Daniel Kulp created BEAM-3640:

             Summary: Checkstyle enforcement of blank lines
                 Key: BEAM-3640
             Project: Beam
          Issue Type: Task
          Components: build-system
            Reporter: Daniel Kulp
            Assignee: Daniel Kulp

Checkstyle has a rule (EmptyLineSeparator) we currently don't use to enforce the use of blank
lines in various places.   In order to reduce the noise in reviews of PR's, I like to start
using it.

This will likely be accomplished via a series of PR's.   Just adding the default EmptyLineSeparator
to the checkstyle rules results in a THOUSANDS of violations which would be hard to review.
  I will likely enable it for one token type at a time, fix the violations on that particular
token type, submit, add then next token type, etc... That should  (hopefully) keep each PR
down to something that can reasonably be reviewed. 

This message was sent by Atlassian JIRA

View raw message