From commits-return-57025-archive-asf-public=cust-asf.ponee.io@beam.apache.org Fri Jan 26 10:49:09 2018 Return-Path: X-Original-To: archive-asf-public@eu.ponee.io Delivered-To: archive-asf-public@eu.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by mx-eu-01.ponee.io (Postfix) with ESMTP id B004B180657 for ; Fri, 26 Jan 2018 10:49:09 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 9FC8F160C3E; Fri, 26 Jan 2018 09:49:09 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id E6EC7160C20 for ; Fri, 26 Jan 2018 10:49:08 +0100 (CET) Received: (qmail 5226 invoked by uid 500); 26 Jan 2018 09:49:08 -0000 Mailing-List: contact commits-help@beam.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@beam.apache.org Delivered-To: mailing list commits@beam.apache.org Received: (qmail 5217 invoked by uid 99); 26 Jan 2018 09:49:08 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd3-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 26 Jan 2018 09:49:08 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd3-us-west.apache.org (ASF Mail Server at spamd3-us-west.apache.org) with ESMTP id 93020180A37 for ; Fri, 26 Jan 2018 09:49:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd3-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -110.311 X-Spam-Level: X-Spam-Status: No, score=-110.311 tagged_above=-999 required=6.31 tests=[ENV_AND_HDR_SPF_MATCH=-0.5, RCVD_IN_DNSWL_MED=-2.3, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_DEF_SPF_WL=-7.5, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd3-us-west.apache.org [10.40.0.10]) (amavisd-new, port 10024) with ESMTP id CsQuXVj-IUdp for ; Fri, 26 Jan 2018 09:49:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 6D5335FB70 for ; Fri, 26 Jan 2018 09:49:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id C7550E0F6D for ; Fri, 26 Jan 2018 09:49:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 40872240FE for ; Fri, 26 Jan 2018 09:49:00 +0000 (UTC) Date: Fri, 26 Jan 2018 09:49:00 +0000 (UTC) From: "Alexey Romanenko (JIRA)" To: commits@beam.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (BEAM-3539) BigtableIO.Write javadoc of some methods is incorrect MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/BEAM-3539?page=3Dcom.atlassian= .jira.plugin.system.issuetabpanels:all-tabpanel ] Alexey Romanenko updated BEAM-3539: ----------------------------------- Description:=20 Some methods in=C2=A0BigtableIO.Write have wrong javadoc which=C2=A0says th= at it returns new instance of=C2=A0BigtableIO.Read. For example: =C2=A0 /** * Returns a new \{@link BigtableIO.Read} that will write into the Cloud Bi= gtable project * indicated by given parameter, requires \{@link #withInstanceId} * to be called to determine the instance. * *

Does not modify this object. */ public Write withProjectId(ValueProvider projectId) \{..} =C2=A0 Actually, it returns new=C2=A0BigtableIO.Write was: Some methods in=C2=A0BigtableIO.Write have wrong javadoc which=C2=A0says th= at it returns new instance of=C2=A0BigtableIO.Read. For example: {{/**}} {{ * Returns a new \{@link BigtableIO.Read} that will write into the Cloud = Bigtable project}} {{ * indicated by given parameter, requires \{@link #withInstanceId}}} {{ * to be called to determine the instance.}} {{ *}} {{ *

Does not modify this object.}} {{ */}} {{}} {{public Write withProjectId(ValueProvider projectId) {}}{{...= }}{{}}}{{}} =C2=A0 Actually, it returns new=C2=A0BigtableIO.Write > BigtableIO.Write javadoc of some methods is incorrect > ----------------------------------------------------- > > Key: BEAM-3539 > URL: https://issues.apache.org/jira/browse/BEAM-3539 > Project: Beam > Issue Type: Improvement > Components: sdk-java-gcp > Affects Versions: 2.2.0 > Reporter: Alexey Romanenko > Priority: Trivial > Fix For: 2.3.0 > > > Some methods in=C2=A0BigtableIO.Write have wrong javadoc which=C2=A0says = that it returns new instance of=C2=A0BigtableIO.Read. > For example: > =C2=A0 > /** > * Returns a new \{@link BigtableIO.Read} that will write into the Cloud = Bigtable project > * indicated by given parameter, requires \{@link #withInstanceId} > * to be called to determine the instance. > * > *

Does not modify this object. > */ > public Write withProjectId(ValueProvider projectId) \{..} > =C2=A0 > Actually, it returns new=C2=A0BigtableIO.Write -- This message was sent by Atlassian JIRA (v7.6.3#76005)