From commits-return-56295-archive-asf-public=cust-asf.ponee.io@beam.apache.org Fri Jan 19 21:41:07 2018 Return-Path: X-Original-To: archive-asf-public@eu.ponee.io Delivered-To: archive-asf-public@eu.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by mx-eu-01.ponee.io (Postfix) with ESMTP id AE8C5180607 for ; Fri, 19 Jan 2018 21:41:07 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 9E577160C36; Fri, 19 Jan 2018 20:41:07 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id E604A160C1B for ; Fri, 19 Jan 2018 21:41:06 +0100 (CET) Received: (qmail 25306 invoked by uid 500); 19 Jan 2018 20:41:06 -0000 Mailing-List: contact commits-help@beam.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@beam.apache.org Delivered-To: mailing list commits@beam.apache.org Received: (qmail 25297 invoked by uid 99); 19 Jan 2018 20:41:06 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 19 Jan 2018 20:41:06 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id B00B01A091F for ; Fri, 19 Jan 2018 20:41:05 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -100.711 X-Spam-Level: X-Spam-Status: No, score=-100.711 tagged_above=-999 required=6.31 tests=[RCVD_IN_DNSWL_LOW=-0.7, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id qDFPyX5GzyEC for ; Fri, 19 Jan 2018 20:41:04 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 9FFA25F473 for ; Fri, 19 Jan 2018 20:41:04 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 814DEE0F75 for ; Fri, 19 Jan 2018 20:41:02 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id AFD37241CC for ; Fri, 19 Jan 2018 20:41:00 +0000 (UTC) Date: Fri, 19 Jan 2018 20:41:00 +0000 (UTC) From: "Larry Li (JIRA)" To: commits@beam.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Created] (BEAM-3502) Avoid use of proto.Builder.clone() in DatastoreIO MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 Larry Li created BEAM-3502: ------------------------------ Summary: Avoid use of proto.Builder.clone() in DatastoreIO Key: BEAM-3502 URL: https://issues.apache.org/jira/browse/BEAM-3502 Project: Beam Issue Type: Improvement Components: beam-model Affects Versions: 2.2.0 Reporter: Larry Li Assignee: Kenneth Knowles Fix For: 2.3.0 DatastoreIO uses proto.Builder.clone() here: [https://github.com/apache/beam/blob/c0f0e1fd63ce1e9dfe1db71adf1c8b9e88ce70= 38/sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/= gcp/datastore/DatastoreV1.java#L893] =C2=A0 It's only used in one place for actual runtime code, but this causes incomp= atibility problems with Google-internal Java proto generation, i.e. we get = a 'NoSuchMethodError' when attempting to run the pipeline with internal bui= ld tools. =C2=A0 This is a known problem that's already been worked around once: https://issues.apache.org/jira/browse/BEAM-2392 ..but the fix only applied to BigtableServiceImpl. This extends those chang= es to DatastoreIO,=C2=A0replacing its single use of clone(). Associated tes= ts shouldn't need refactoring, as this only appears as a problem at runtime= . -- This message was sent by Atlassian JIRA (v7.6.3#76005)