beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Larry Li (JIRA)" <>
Subject [jira] [Created] (BEAM-3502) Avoid use of proto.Builder.clone() in DatastoreIO
Date Fri, 19 Jan 2018 20:41:00 GMT
Larry Li created BEAM-3502:

             Summary: Avoid use of proto.Builder.clone() in DatastoreIO
                 Key: BEAM-3502
             Project: Beam
          Issue Type: Improvement
          Components: beam-model
    Affects Versions: 2.2.0
            Reporter: Larry Li
            Assignee: Kenneth Knowles
             Fix For: 2.3.0

DatastoreIO uses proto.Builder.clone() here:



It's only used in one place for actual runtime code, but this causes incompatibility problems
with Google-internal Java proto generation, i.e. we get a 'NoSuchMethodError' when attempting
to run the pipeline with internal build tools.


This is a known problem that's already been worked around once:

..but the fix only applied to BigtableServiceImpl. This extends those changes to DatastoreIO, replacing
its single use of clone(). Associated tests shouldn't need refactoring, as this only appears
as a problem at runtime.

This message was sent by Atlassian JIRA

View raw message