beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Kenneth Knowles (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (BEAM-3279) Deprecate and remove Coder consistentWithEquals in favor of overriding structuredValue
Date Wed, 03 Jan 2018 19:57:00 GMT

     [ https://issues.apache.org/jira/browse/BEAM-3279?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Kenneth Knowles updated BEAM-3279:
----------------------------------
    Labels: starter  (was: )

> Deprecate and remove Coder consistentWithEquals in favor of overriding structuredValue
> --------------------------------------------------------------------------------------
>
>                 Key: BEAM-3279
>                 URL: https://issues.apache.org/jira/browse/BEAM-3279
>             Project: Beam
>          Issue Type: Improvement
>          Components: sdk-java-core
>            Reporter: Kenneth Knowles
>            Priority: Minor
>              Labels: starter
>
> Summary of discussion linked below:
> consistentWithEquals() is redundant w.r.t. structuralValue(), and should be deprecated.
I think our mutation detectors are already using structuralValue(), so the work here would
be to simply mark the method deprecated, remove all remaining overrides in the SDK, and document
that overriding the method is a no-op.
> https://lists.apache.org/thread.html/8b2dcf09ba8e46b3c008293d99e4028d10463148b68326687dc29a4d@%3Cdev.beam.apache.org%3E



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message