beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <>
Subject [jira] [Commented] (BEAM-3160) Type based coder inference incorrectly assumes that a coder for one type is equivalent to every other coder for that type.
Date Thu, 18 Jan 2018 00:31:00 GMT


ASF GitHub Bot commented on BEAM-3160:

lukecwik opened a new pull request #4433: [BEAM-3160] Prevent issue where we would choose
which coder to use arbitrarily when it is over specified with multiple coders.
   Follow this checklist to help us incorporate your contribution quickly and easily:
    - [x] Make sure there is a [JIRA issue](
filed for the change (usually before you start working on it).  Trivial changes like typos
do not require a JIRA issue.  Your pull request should address just this issue, without pulling
in other changes.
    - [x] Each commit in the pull request should have a meaningful subject line and body.
    - [x] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`,
where you replace `BEAM-XXX` with the appropriate JIRA issue.
    - [x] Write a pull request description that is detailed enough to understand what the
pull request does, how, and why.
    - [ ] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will
be performed on your pull request automatically.
    - [ ] If this contribution is large, please file an Apache [Individual Contributor License

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:

> Type based coder inference incorrectly assumes that a coder for one type is equivalent
to every other coder for that type.
> --------------------------------------------------------------------------------------------------------------------------
>                 Key: BEAM-3160
>                 URL:
>             Project: Beam
>          Issue Type: Bug
>          Components: sdk-java-core
>            Reporter: Luke Cwik
>            Priority: Major
>             Fix For: 2.3.0
> We should prevent coder inference from assuming that two coders for the same type are
> Two Avro GenericRecord coders with different schemas are considered identical and an
arbitrary one is returned by the Coder/Type inference system if the GenericRecord type appears
multiple times.
> e.g.
> *KvCoder.of(IterableCoder.of(AvroCoder.of(SchemaA)), IterableCoder.of(AvroCoder.of(SchemaB)))*
after coder inference for the type *KV<Iterable<GenericRecord>, Iterable<GenericRecord>>*
will return *KvCoder.of(IterableCoder.of(AvroCoder.of(SchemaX)), IterableCoder.of(AvroCoder.of(SchemaX)))*
where SchemaX is either SchemaA or SchemaB.
> Code:
and other Type -> Coder maps in the same file should prevent insertion if the type already
exists and the coders aren't equal.

This message was sent by Atlassian JIRA

View raw message