beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BEAM-2345) Version configuration of plugins / dependencies in root pom.xml is inconsistent
Date Wed, 24 Jan 2018 02:16:00 GMT

    [ https://issues.apache.org/jira/browse/BEAM-2345?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16336767#comment-16336767
] 

ASF GitHub Bot commented on BEAM-2345:
--------------------------------------

aaltay closed pull request #3205: [BEAM-2345] Make versioning in root pom consistent.
URL: https://github.com/apache/beam/pull/3205
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/pom.xml b/pom.xml
index 1bdaa97f525..1460891faf3 100644
--- a/pom.xml
+++ b/pom.xml
@@ -100,7 +100,14 @@
     <!-- Do not add additional surefire arguments by default -->
     <beamSurefireArgline />
 
-    <!-- If updating dependencies, please update any relevant javadoc offlineLinks -->
+    <!-- Maven minimum version -->
+    <maven.version>3.2</maven.version>
+
+    <!--
+      This section contains versions for dependencies. All versions should be
+      specified here; subprojects should use properties defined in this section.
+      If updating dependencies, please update any relevant javadoc offlineLinks.
+    -->
     <apache.commons.compress.version>1.14</apache.commons.compress.version>
     <apache.commons.lang.version>3.6</apache.commons.lang.version>
     <apache.commons.text.version>1.1</apache.commons.text.version>
@@ -109,13 +116,16 @@
     <avro.version>1.8.2</avro.version>
     <bigquery.version>v2-rev295-1.22.0</bigquery.version>
     <bigtable.version>0.9.7.1</bigtable.version>
-    <cloudresourcemanager.version>v1-rev6-1.22.0</cloudresourcemanager.version>
-    <pubsubgrpc.version>0.1.0</pubsubgrpc.version>
+    <byte-buddy.version>1.6.8</byte-buddy.version>
     <clouddebugger.version>v2-rev8-1.22.0</clouddebugger.version>
+    <cloudresourcemanager.version>v1-rev6-1.22.0</cloudresourcemanager.version>
     <dataflow.version>v1b3-rev198-1.20.0</dataflow.version>
     <dataflow.proto.version>0.5.160222</dataflow.proto.version>
     <datastore.client.version>1.4.0</datastore.client.version>
     <datastore.proto.version>1.3.0</datastore.proto.version>
+    <error_prone_annotations.version>2.0.15</error_prone_annotations.version>
+    <findbugs.version>3.0.1</findbugs.version>
+    <gax-grpc.version>0.20.0</gax-grpc.version>
     <google-api-common.version>1.0.0-rc2</google-api-common.version>
     <google-auto-service.version>1.0-rc2</google-auto-service.version>
     <google-auto-value.version>1.4.1</google-auto-value.version>
@@ -124,9 +134,9 @@
     <google-cloud-bigdataoss.version>1.4.5</google-cloud-bigdataoss.version>
     <google-cloud-core.version>1.0.2</google-cloud-core.version>
     <google-cloud-dataflow-java-proto-library-all.version>0.5.160304</google-cloud-dataflow-java-proto-library-all.version>
-    <guava.version>20.0</guava.version>
     <grpc.version>1.2.0</grpc.version>
     <grpc-google-common-protos.version>0.1.9</grpc-google-common-protos.version>
+    <guava.version>20.0</guava.version>
     <!--
       This is the version of Hadoop used to compile the module that depend on Hadoop.
       This dependency is defined with a provided scope.
@@ -135,7 +145,6 @@
     <hadoop.version>2.7.3</hadoop.version>
     <hamcrest.version>1.3</hamcrest.version>
     <jackson.version>2.8.9</jackson.version>
-    <findbugs.version>3.0.1</findbugs.version>
     <joda.version>2.4</joda.version>
     <junit.version>4.12</junit.version>
     <mockito.version>1.9.5</mockito.version>
@@ -143,6 +152,8 @@
     <netty.tcnative.version>1.1.33.Fork26</netty.tcnative.version>
     <protobuf.version>3.2.0</protobuf.version>
     <pubsub.version>v1-rev10-1.22.0</pubsub.version>
+    <pubsubgrpc.version>0.1.0</pubsubgrpc.version>
+    <puppycrawl.tools.checkstyle.version>6.19</puppycrawl.tools.checkstyle.version>
     <slf4j.version>1.7.14</slf4j.version>
     <spanner.version>0.20.0-beta</spanner.version>
     <spark.version>1.6.3</spark.version>
@@ -152,24 +163,43 @@
     <woodstox.version>4.4.1</woodstox.version>
     <spring.version>4.3.5.RELEASE</spring.version>
     <snappy-java.version>1.1.4-M3</snappy-java.version>
-
-    <os-maven-plugin.version>1.5.0.Final</os-maven-plugin.version>
+    <tycho-compiler-jdt.version>0.26.0</tycho-compiler-jdt.version>
+
+    <!-- This section contains versions for Maven plugins. -->
+    <apache-rat-plugin.version>0.12</apache-rat-plugin.version>
+    <build-helper-maven-plugin.version>3.0.0</build-helper-maven-plugin.version>
+    <coveralls-maven-plugin.version>4.3.0</coveralls-maven-plugin.version>
+    <eclipse.m2e.lifecycle-mapping.version>1.0.0</eclipse.m2e.lifecycle-mapping.version>
+    <exec-maven-plugin.version>1.5.0</exec-maven-plugin.version>
+    <extra-enforcer-rules.version>1.0-beta-6</extra-enforcer-rules.version>
     <groovy-maven-plugin.version>2.0</groovy-maven-plugin.version>
-    <surefire-plugin.version>2.20</surefire-plugin.version>
     <failsafe-plugin.version>2.20</failsafe-plugin.version>
+    <findbugs-maven-plugin.version>3.0.4</findbugs-maven-plugin.version>
+    <jacoco-maven-plugin.version>0.7.8</jacoco-maven-plugin.version>
+    <maven-antrun-plugin.version>1.8</maven-antrun-plugin.version>
+    <maven-assembly-plugin.version>3.0.0</maven-assembly-plugin.version>
+    <maven-checkstyle-plugin.version>2.17</maven-checkstyle-plugin.version>
+    <maven-clean-plugin.version>3.0.0</maven-clean-plugin.version>
     <maven-compiler-plugin.version>3.6.2</maven-compiler-plugin.version>
     <maven-dependency-plugin.version>3.0.1</maven-dependency-plugin.version>
+    <maven-deploy-plugin.version>2.8.2</maven-deploy-plugin.version>
     <maven-enforcer-plugin.version>3.0.0-M1</maven-enforcer-plugin.version>
     <maven-exec-plugin.version>1.6.0</maven-exec-plugin.version>
     <maven-jar-plugin.version>3.0.2</maven-jar-plugin.version>
     <maven-javadoc-plugin.version>3.0.0-M1</maven-javadoc-plugin.version>
+    <maven-release-plugin.version>2.5.3</maven-release-plugin.version>
     <maven-resources-plugin.version>3.0.2</maven-resources-plugin.version>
     <maven-shade-plugin.version>3.0.0</maven-shade-plugin.version>
+    <maven-source-plugin.version>3.0.1</maven-source-plugin.version>
+    <os-maven-plugin.version>1.5.0.Final</os-maven-plugin.version>
+    <protobuf-maven-plugin.version>0.5.0</protobuf-maven-plugin.version>
+    <surefire-plugin.version>2.20</surefire-plugin.version>
+    <versions-maven-plugin.version>2.3</versions-maven-plugin.version>
 
+    <!-- Compiler options -->
     <compiler.error.flag>-Werror</compiler.error.flag>
     <compiler.default.pkginfo.flag>-Xpkginfo:always</compiler.default.pkginfo.flag>
     <compiler.default.exclude>nothing</compiler.default.exclude>
-    <gax-grpc.version>0.20.0</gax-grpc.version>
 
     <!-- standard binary for kubectl -->
     <kubectl>kubectl</kubectl>
@@ -346,7 +376,7 @@
                 <dependency>
                   <groupId>org.eclipse.tycho</groupId>
                   <artifactId>tycho-compiler-jdt</artifactId>
-                  <version>0.26.0</version>
+                  <version>${tycho-compiler-jdt.version}</version>
                 </dependency>
               </dependencies>
             </plugin>
@@ -1085,7 +1115,7 @@
       <dependency>
         <groupId>com.google.errorprone</groupId>
         <artifactId>error_prone_annotations</artifactId>
-        <version>2.0.15</version>
+        <version>${error_prone_annotations.version}</version>
       </dependency>
 
       <dependency>
@@ -1103,7 +1133,7 @@
       <dependency>
         <groupId>net.bytebuddy</groupId>
         <artifactId>byte-buddy</artifactId>
-        <version>1.6.8</version>
+        <version>${byte-buddy.version}</version>
       </dependency>
 
       <dependency>
@@ -1261,24 +1291,24 @@
         <plugin>
           <groupId>org.xolstice.maven.plugins</groupId>
           <artifactId>protobuf-maven-plugin</artifactId>
-          <version>0.5.0</version>
+          <version>${protobuf-maven-plugin.version}</version>
         </plugin>
 
         <plugin>
           <groupId>org.apache.maven.plugins</groupId>
           <artifactId>maven-antrun-plugin</artifactId>
-          <version>1.8</version>
+          <version>${maven-antrun-plugin.version}</version>
         </plugin>
 
         <plugin>
           <groupId>org.apache.maven.plugins</groupId>
           <artifactId>maven-checkstyle-plugin</artifactId>
-          <version>2.17</version>
+          <version>${maven-checkstyle-plugin.version}</version>
           <dependencies>
             <dependency>
               <groupId>com.puppycrawl.tools</groupId>
               <artifactId>checkstyle</artifactId>
-              <version>6.19</version>
+              <version>${puppycrawl.tools.checkstyle.version}</version>
             </dependency>
             <dependency>
               <groupId>org.apache.beam</groupId>
@@ -1362,7 +1392,7 @@
         <plugin>
           <groupId>org.apache.maven.plugins</groupId>
           <artifactId>maven-deploy-plugin</artifactId>
-          <version>2.8.2</version>
+          <version>${maven-deploy-plugin.version}</version>
         </plugin>
 
         <plugin>
@@ -1391,7 +1421,7 @@
         <plugin>
           <groupId>org.apache.maven.plugins</groupId>
           <artifactId>maven-source-plugin</artifactId>
-          <version>3.0.1</version>
+          <version>${maven-source-plugin.version}</version>
         </plugin>
 
         <plugin>
@@ -1416,7 +1446,7 @@
         <plugin>
           <groupId>org.apache.rat</groupId>
           <artifactId>apache-rat-plugin</artifactId>
-          <version>0.12</version>
+          <version>${apache-rat-plugin.version}</version>
           <configuration>
             <reportFile>${project.build.directory}/${project.build.finalName}.rat</reportFile>
             <excludeSubProjects>false</excludeSubProjects>
@@ -1456,13 +1486,13 @@
         <plugin>
           <groupId>org.codehaus.mojo</groupId>
           <artifactId>versions-maven-plugin</artifactId>
-          <version>2.3</version>
+          <version>${versions-maven-plugin.version}</version>
         </plugin>
 
         <plugin>
           <groupId>org.codehaus.mojo</groupId>
           <artifactId>exec-maven-plugin</artifactId>
-          <version>1.5.0</version>
+          <version>${exec-maven-plugin.version}</version>
           <configuration>
             <cleanupDaemonThreads>false</cleanupDaemonThreads>
             <systemProperties>
@@ -1478,7 +1508,7 @@
         <plugin>
           <groupId>org.jacoco</groupId>
           <artifactId>jacoco-maven-plugin</artifactId>
-          <version>0.7.8</version>
+          <version>${jacoco-maven-plugin.version}</version>
           <executions>
             <execution>
               <goals>
@@ -1508,7 +1538,7 @@
         <plugin>
           <groupId>org.eluder.coveralls</groupId>
           <artifactId>coveralls-maven-plugin</artifactId>
-          <version>4.3.0</version>
+          <version>${coveralls-maven-plugin.version}</version>
         </plugin>
 
         <plugin>
@@ -1545,7 +1575,7 @@
         <plugin>
           <groupId>org.eclipse.m2e</groupId>
           <artifactId>lifecycle-mapping</artifactId>
-          <version>1.0.0</version>
+          <version>${eclipse.m2e.lifecycle-mapping.version}</version>
           <configuration>
             <lifecycleMappingMetadata>
               <pluginExecutions>
@@ -1662,7 +1692,7 @@
         <plugin>
           <groupId>org.apache.maven.plugins</groupId>
           <artifactId>maven-release-plugin</artifactId>
-          <version>2.5.3</version>
+          <version>${maven-release-plugin.version}</version>
           <configuration>
             <releaseProfiles>release</releaseProfiles>
             <preparationGoals>clean install</preparationGoals>
@@ -1676,7 +1706,7 @@
         <plugin>
           <groupId>org.apache.maven.plugins</groupId>
           <artifactId>maven-assembly-plugin</artifactId>
-          <version>3.0.0</version>
+          <version>${maven-assembly-plugin.version}</version>
           <executions>
             <execution>
               <id>source-release-assembly</id>
@@ -1690,7 +1720,7 @@
         <plugin>
           <groupId>org.codehaus.mojo</groupId>
           <artifactId>findbugs-maven-plugin</artifactId>
-          <version>3.0.4</version>
+          <version>${findbugs-maven-plugin.version}</version>
           <dependencies>
             <dependency>
               <groupId>org.apache.beam</groupId>
@@ -1729,7 +1759,7 @@
         <plugin>
           <groupId>org.apache.maven.plugins</groupId>
           <artifactId>maven-clean-plugin</artifactId>
-          <version>3.0.0</version>
+          <version>${maven-clean-plugin.version}</version>
           <configuration>
             <filesets>
               <fileset>
@@ -1750,7 +1780,7 @@
         <plugin>
           <groupId>org.codehaus.mojo</groupId>
           <artifactId>build-helper-maven-plugin</artifactId>
-          <version>3.0.0</version>
+          <version>${build-helper-maven-plugin.version}</version>
           <executions>
             <execution>
               <id>render-artifact-id</id>
@@ -1817,8 +1847,7 @@
                   <version>[1.7,)</version>
                 </requireJavaVersion>
                 <requireMavenVersion>
-                  <!-- Keep aligned with preqrequisite section below. -->
-                  <version>[3.2,)</version>
+                  <version>[${maven.version},)</version>
                 </requireMavenVersion>
               </rules>
             </configuration>
@@ -1845,7 +1874,7 @@
           <dependency>
             <groupId>org.codehaus.mojo</groupId>
             <artifactId>extra-enforcer-rules</artifactId>
-            <version>1.0-beta-6</version>
+            <version>${extra-enforcer-rules.version}</version>
           </dependency>
         </dependencies>
       </plugin>
@@ -1866,7 +1895,7 @@
       <plugin>
         <groupId>org.apache.maven.plugins</groupId>
         <artifactId>maven-resources-plugin</artifactId>
-        <version>3.0.2</version>
+        <version>${maven-resources-plugin.version}</version>
         <inherited>false</inherited>
         <executions>
           <execution>
@@ -1899,7 +1928,7 @@
       <plugin>
         <groupId>org.codehaus.mojo</groupId>
         <artifactId>versions-maven-plugin</artifactId>
-        <version>2.3</version>
+        <version>${versions-maven-plugin.version}</version>
         <reportSets>
           <reportSet>
             <reports>
@@ -1913,7 +1942,6 @@
   </reporting>
 
   <prerequisites>
-    <!-- Keep aligned with requireMavenVersion section above. -->
-    <maven>3.2</maven>
+    <maven>${maven.version}</maven>
   </prerequisites>
 </project>


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Version configuration of plugins / dependencies in root pom.xml is inconsistent
> -------------------------------------------------------------------------------
>
>                 Key: BEAM-2345
>                 URL: https://issues.apache.org/jira/browse/BEAM-2345
>             Project: Beam
>          Issue Type: Bug
>          Components: build-system
>            Reporter: Jason Kuster
>            Assignee: Jason Kuster
>            Priority: Minor
>             Fix For: 2.3.0
>
>
> Versioning in root pom.xml in some places is controlled by the properties section, sometimes
is just inline. Move all versioning of plugins / dependencies to properties section.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Mime
View raw message