Mailing-List: contact commits-help@beam.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@beam.apache.org
Date: Fri, 15 Dec 2017 18:01:00 +0000 (UTC)
From: "Anton Kedin (JIRA)" <jira@apache.org>
To: commits@beam.apache.org
Message-ID: <JIRA.13125290.1513360834000.471067.1513360860194@Atlassian.JIRA>
In-Reply-To: <JIRA.13125290.1513360834000@Atlassian.JIRA>
References: <JIRA.13125290.1513360834000@Atlassian.JIRA> <JIRA.13125290.1513360834145@jira-lw-us.apache.org>
Subject: [jira] [Created] (BEAM-3360) [SQL] Do not assign triggers for
 HOP/TUMBLE
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Fri, 15 Dec 2017 18:01:04 -0000

Anton Kedin created BEAM-3360:
---------------------------------

             Summary: [SQL] Do not assign triggers for HOP/TUMBLE
                 Key: BEAM-3360
                 URL: https://issues.apache.org/jira/browse/BEAM-3360
             Project: Beam
          Issue Type: Task
          Components: dsl-sql
            Reporter: Anton Kedin


Currently when parsing HOP/TUMBLE expressions we create a repeating trigger for the defined windows, see:

{code:java|title=BeamAggregationRule.java}

  private Trigger createTriggerWithDelay(GregorianCalendar delayTime) {
    return Repeatedly.forever(AfterWatermark.pastEndOfWindow().withLateFirings(AfterProcessingTime
        .pastFirstElementInPane().plusDelayOf(Duration.millis(delayTime.getTimeInMillis()))));
  }
{code}

This will not work correctly with joins, as joins with multiple trigger firings are currently broken: https://issues.apache.org/jira/browse/BEAM-3190 .

Even if joins with multiple firings worked correctly, SQL parsing stage is still probably an incorrect place to infer them.

Better alternatives:
 - inherit the user-defined triggers for the input pcollection without modification;
 - triggering at sinks ( https://s.apache.org/beam-sink-triggers ) might define a way to backpropagate triggers with correct semantics;


--
This message was sent by Atlassian JIRA
(v6.4.14#64029)