Mailing-List: contact commits-help@beam.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@beam.apache.org
Date: Wed, 20 Dec 2017 00:18:00 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: commits@beam.apache.org
Message-ID: <JIRA.13125089.1513308748000.498492.1513729080418@Atlassian.JIRA>
In-Reply-To: <JIRA.13125089.1513308748000@Atlassian.JIRA>
References: <JIRA.13125089.1513308748000@Atlassian.JIRA> <JIRA.13125089.1513308748172@jira-lw-us.apache.org>
Subject: [jira] [Commented] (BEAM-3357) Python SDK head fails to run tests
 due to Requirement.parse('protobuf<=3.4.0,>=3.2.0')
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Wed, 20 Dec 2017 00:18:07 -0000


    [ https://issues.apache.org/jira/browse/BEAM-3357?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16297687#comment-16297687 ] 

ASF GitHub Bot commented on BEAM-3357:
--------------------------------------

aaltay closed pull request #4274: [BEAM-3357] Remove upper bound for protobuf
URL: https://github.com/apache/beam/pull/4274
 
 
This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/sdks/python/gen_protos.py b/sdks/python/gen_protos.py
index 8964f3a2b32..f5aa0993ef5 100644
--- a/sdks/python/gen_protos.py
+++ b/sdks/python/gen_protos.py
@@ -31,9 +31,7 @@
 import time
 import warnings
 
-# grpcio 1.8.1 requires protobuf >= 3.5
-# TODO(BEAM-3357): Remove the upper bound.
-GRPC_TOOLS = 'grpcio-tools>=1.3.5,<=1.7.3'
+GRPC_TOOLS = 'grpcio-tools>=1.3.5,<2'
 
 BEAM_PROTO_PATHS = [
   os.path.join('..', '..', 'model', 'pipeline', 'src', 'main', 'proto'),
diff --git a/sdks/python/setup.py b/sdks/python/setup.py
index 53848614d6d..b022051af3b 100644
--- a/sdks/python/setup.py
+++ b/sdks/python/setup.py
@@ -98,13 +98,11 @@ def get_version():
     'avro>=1.8.1,<2.0.0',
     'crcmod>=1.7,<2.0',
     'dill==0.2.6',
-    # grpcio 1.8.1 requires protobuf >= 3.5
-    # TODO(BEAM-3357): Remove the upper bound.
-    'grpcio>=1.0,<=1.7.3',
+    'grpcio>=1.0,<2',
     'httplib2>=0.8,<0.10',
     'mock>=1.0.1,<3.0.0',
     'oauth2client>=2.0.1,<4.0.0',
-    'protobuf>=3.2.0,<=3.3.0',
+    'protobuf>=3.2.0,<4',
     'pyyaml>=3.12,<4.0.0',
     'pyvcf>=0.6.8,<0.7.0',
     # Six 1.11.0 incompatible with apitools.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Python SDK head fails to run tests due to Requirement.parse('protobuf<=3.4.0,>=3.2.0')
> --------------------------------------------------------------------------------------
>
>                 Key: BEAM-3357
>                 URL: https://issues.apache.org/jira/browse/BEAM-3357
>             Project: Beam
>          Issue Type: Bug
>          Components: sdk-py-core
>            Reporter: Chamikara Jayalath
>            Priority: Critical
>
> Error is:
> running build_ext
> Traceback (most recent call last):
>   File "setup.py", line 202, in <module>
>     'test': generate_protos_first(test),
>   File "/Users/chamikara/testing/test_py_12_14_2017_2/env_proto_3.4/lib/python2.7/site-packages/setuptools/__init__.py", line 129, in setup
>     return distutils.core.setup(**attrs)
>   File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/distutils/core.py", line 151, in setup
>     dist.run_commands()
>   File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/distutils/dist.py", line 953, in run_commands
>     self.run_command(cmd)
>   File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/distutils/dist.py", line 972, in run_command
>     cmd_obj.run()
>   File "setup.py", line 142, in run
>     super(cmd, self).run()
>   File "/Users/chamikara/testing/test_py_12_14_2017_2/env_proto_3.4/lib/python2.7/site-packages/setuptools/command/test.py", line 225, in run
>     with self.project_on_sys_path():
>   File "/System/Library/Frameworks/Python.framework/Versions/2.7/lib/python2.7/contextlib.py", line 17, in __enter__
>     return self.gen.next()
>   File "/Users/chamikara/testing/test_py_12_14_2017_2/env_proto_3.4/lib/python2.7/site-packages/setuptools/command/test.py", line 164, in project_on_sys_path
>     require('%s==%s' % (ei_cmd.egg_name, ei_cmd.egg_version))
>   File "/Users/chamikara/testing/test_py_12_14_2017_2/env_proto_3.4/lib/python2.7/site-packages/pkg_resources/__init__.py", line 984, in require
>     needed = self.resolve(parse_requirements(requirements))
>   File "/Users/chamikara/testing/test_py_12_14_2017_2/env_proto_3.4/lib/python2.7/site-packages/pkg_resources/__init__.py", line 875, in resolve
>     raise VersionConflict(dist, req).with_context(dependent_req)
> pkg_resources.ContextualVersionConflict: (protobuf 3.5.0.post1 (/Users/chamikara/testing/test_py_12_14_2017_2/beam/sdks/python/.eggs/protobuf-3.5.0.post1-py2.7.egg), Requirement.parse('protobuf<=3.4.0,>=3.2.0'), set(['apache-beam']))
> Seems like grpcio did a release today which is breaking us: https://pypi.python.org/pypi/grpcio/1.8.1
> We have to either bump our protobuf dependency or reduce the upper bound of grpcio dependency to previous release (1.7.3). 


--
This message was sent by Atlassian JIRA
(v6.4.14#64029)