Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id E3884200D5A for ; Thu, 14 Dec 2017 22:53:04 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id E218A160C16; Thu, 14 Dec 2017 21:53:04 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 345BE160BFC for ; Thu, 14 Dec 2017 22:53:04 +0100 (CET) Received: (qmail 2421 invoked by uid 500); 14 Dec 2017 21:53:03 -0000 Mailing-List: contact commits-help@beam.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@beam.apache.org Delivered-To: mailing list commits@beam.apache.org Received: (qmail 2412 invoked by uid 99); 14 Dec 2017 21:53:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 14 Dec 2017 21:53:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 00486C18DB for ; Thu, 14 Dec 2017 21:53:03 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -99.211 X-Spam-Level: X-Spam-Status: No, score=-99.211 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id h_JLL1vzXHkN for ; Thu, 14 Dec 2017 21:53:02 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id B29805F297 for ; Thu, 14 Dec 2017 21:53:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id EA2CFE129D for ; Thu, 14 Dec 2017 21:53:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 342B2212FF for ; Thu, 14 Dec 2017 21:53:00 +0000 (UTC) Date: Thu, 14 Dec 2017 21:53:00 +0000 (UTC) From: "Kenneth Knowles (JIRA)" To: commits@beam.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Resolved] (BEAM-3264) Update contribution guide w/ suggestions for GitHub merge button MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Thu, 14 Dec 2017 21:53:05 -0000 [ https://issues.apache.org/jira/browse/BEAM-3264?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Kenneth Knowles resolved BEAM-3264. ----------------------------------- Resolution: Fixed Fix Version/s: Not applicable > Update contribution guide w/ suggestions for GitHub merge button > ---------------------------------------------------------------- > > Key: BEAM-3264 > URL: https://issues.apache.org/jira/browse/BEAM-3264 > Project: Beam > Issue Type: Bug > Components: website > Reporter: Kenneth Knowles > Assignee: Kenneth Knowles > Fix For: Not applicable > > > Today our guide for committers has instructions for rebasing, adjusting commits, etc. > I think with the use of gitbox, we should encourage using the GitHub button, keeping a merge commit when possibly, but editing the default message since it references useless information like the transient branch that was merged. -- This message was sent by Atlassian JIRA (v6.4.14#64029)