Mailing-List: contact commits-help@beam.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@beam.apache.org
Date: Sat, 2 Dec 2017 00:28:12 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: commits@beam.apache.org
Message-ID: <JIRA.13048594.1488823930000.369878.1512174492174@Atlassian.JIRA>
In-Reply-To: <JIRA.13048594.1488823930000@Atlassian.JIRA>
References: <JIRA.13048594.1488823930000@Atlassian.JIRA> <JIRA.13048594.1488823930105@jira-lw-us.apache.org>
Subject: [jira] [Commented] (BEAM-1630) Add Splittable DoFn to Python SDK
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Sat, 02 Dec 2017 00:28:23 -0000


    [ https://issues.apache.org/jira/browse/BEAM-1630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16275276#comment-16275276 ] 

ASF GitHub Bot commented on BEAM-1630:
--------------------------------------

chamikaramj commented on a change in pull request #4064: [BEAM-1630] Adds support for processing Splittable DoFns using DirectRunner.
URL: https://github.com/apache/beam/pull/4064#discussion_r154203185
 
 
 ##########
 File path: sdks/python/apache_beam/runners/direct/sdf_direct_runner_test.py
 ##########
 @@ -0,0 +1,237 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements.  See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License.  You may obtain a copy of the License at
+#
+#    http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+
+"""Unit tests for SDF implementation for DirectRunner."""
+
+import logging
+import os
+import unittest
+
+import apache_beam as beam
+from apache_beam import DoFn
+from apache_beam.io import filebasedsource_test
+from apache_beam.io.restriction_trackers import OffsetRestrictionTracker
+from apache_beam.testing.test_pipeline import TestPipeline
+from apache_beam.testing.util import assert_that
+from apache_beam.testing.util import equal_to
+from apache_beam.transforms.core import ProcessContinuation
+from apache_beam.transforms.core import RestrictionProvider
+from apache_beam.transforms.trigger import AccumulationMode
+from apache_beam.transforms.window import SlidingWindows
+from apache_beam.transforms.window import TimestampedValue
+
+
+class ReadFilesProvider(RestrictionProvider):
+
+  def restriction_coder(self):
+    return object()
+
+  def initial_restriction(self, element):
+    size = os.path.getsize(element)
+    return (0, size)
+
+  def create_tracker(self, restriction):
+    return OffsetRestrictionTracker(restriction[0], restriction[1])
+
+  def split(self, element, restriction):
+    return [restriction,]
+
+
+class ReadFiles(DoFn):
+
+  def __init__(self, resume_count=None):
+    self._resume_count = resume_count
+
+  def process(
+      self, element, restriction_tracker=ReadFilesProvider(), *args, **kwargs):
+    file_name = element
+    file = open(file_name, 'rb')
 
 Review comment:
   Done (added with statement).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Add Splittable DoFn to Python SDK
> ---------------------------------
>
>                 Key: BEAM-1630
>                 URL: https://issues.apache.org/jira/browse/BEAM-1630
>             Project: Beam
>          Issue Type: Improvement
>          Components: sdk-py-core
>            Reporter: Chamikara Jayalath
>            Assignee: Chamikara Jayalath
>
> Splittable DoFn [1] is currently being implemented for Java SDK [2]. We should add this to Python SDK as well.
> Following document proposes an API for this.
> https://docs.google.com/document/d/1h_zprJrOilivK2xfvl4L42vaX4DMYGfH1YDmi-s_ozM/edit?usp=sharing
> [1] https://s.apache.org/splittable-do-fn
> [2] https://lists.apache.org/thread.html/0ce61ac162460a149d5c93cdface37cc383f8030fe86ca09e5699b18@%3Cdev.beam.apache.org%3E


--
This message was sent by Atlassian JIRA
(v6.4.14#64029)