Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 766AF200D62 for ; Sat, 2 Dec 2017 01:28:20 +0100 (CET) Received: by cust-asf.ponee.io (Postfix) id 74EE3160C19; Sat, 2 Dec 2017 00:28:20 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id BF824160C06 for ; Sat, 2 Dec 2017 01:28:19 +0100 (CET) Received: (qmail 61956 invoked by uid 500); 2 Dec 2017 00:28:19 -0000 Mailing-List: contact commits-help@beam.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@beam.apache.org Delivered-To: mailing list commits@beam.apache.org Received: (qmail 61778 invoked by uid 99); 2 Dec 2017 00:28:18 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 02 Dec 2017 00:28:18 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 34B75C2F66 for ; Sat, 2 Dec 2017 00:28:18 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -99.011 X-Spam-Level: X-Spam-Status: No, score=-99.011 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, KB_WAM_FROM_NAME_SINGLEWORD=0.2, SPF_PASS=-0.001, T_RP_MATCHES_RCVD=-0.01, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id e7H1-q66kL-2 for ; Sat, 2 Dec 2017 00:28:17 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 0D58C610D4 for ; Sat, 2 Dec 2017 00:28:13 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 5685EE08C6 for ; Sat, 2 Dec 2017 00:28:12 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id A5D67255D3 for ; Sat, 2 Dec 2017 00:28:11 +0000 (UTC) Date: Sat, 2 Dec 2017 00:28:11 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: commits@beam.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (BEAM-1630) Add Splittable DoFn to Python SDK MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Sat, 02 Dec 2017 00:28:20 -0000 [ https://issues.apache.org/jira/browse/BEAM-1630?page=3Dcom.atlassian.= jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D16275= 271#comment-16275271 ]=20 ASF GitHub Bot commented on BEAM-1630: -------------------------------------- chamikaramj commented on a change in pull request #4064: [BEAM-1630] Adds s= upport for processing Splittable DoFns using DirectRunner. URL: https://github.com/apache/beam/pull/4064#discussion_r154223462 =20 =20 ########## File path: sdks/python/apache_beam/runners/direct/transform_evaluator.py ########## @@ -191,8 +194,6 @@ def __init__(self, evaluation_context, applied_ptransf= orm, self._execution_context =3D evaluation_context.get_execution_context( applied_ptransform) self.scoped_metrics_container =3D scoped_metrics_container - with scoped_metrics_container: - self.start_bundle() =20 Review comment: =F0=9F=91=8D=20 ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on GitHub and use the URL above to go to the specific comment. =20 For queries about this service, please contact Infrastructure at: users@infra.apache.org > Add Splittable DoFn to Python SDK > --------------------------------- > > Key: BEAM-1630 > URL: https://issues.apache.org/jira/browse/BEAM-1630 > Project: Beam > Issue Type: Improvement > Components: sdk-py-core > Reporter: Chamikara Jayalath > Assignee: Chamikara Jayalath > > Splittable DoFn [1] is currently being implemented for Java SDK [2]. We s= hould add this to Python SDK as well. > Following document proposes an API for this. > https://docs.google.com/document/d/1h_zprJrOilivK2xfvl4L42vaX4DMYGfH1YDmi= -s_ozM/edit?usp=3Dsharing > [1] https://s.apache.org/splittable-do-fn > [2] https://lists.apache.org/thread.html/0ce61ac162460a149d5c93cdface37cc= 383f8030fe86ca09e5699b18@%3Cdev.beam.apache.org%3E -- This message was sent by Atlassian JIRA (v6.4.14#64029)