beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BEAM-3395) Python postcommit always runs on beam3
Date Thu, 28 Dec 2017 21:11:00 GMT

    [ https://issues.apache.org/jira/browse/BEAM-3395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16305735#comment-16305735
] 

ASF GitHub Bot commented on BEAM-3395:
--------------------------------------

lukecwik closed pull request #4329: [BEAM-3395] Allow Python postcommits to run on beam{1,2,3}.
URL: https://github.com/apache/beam/pull/4329
 
 
   

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/.test-infra/jenkins/job_beam_PostCommit_Python_ValidatesRunner_Dataflow.groovy
b/.test-infra/jenkins/job_beam_PostCommit_Python_ValidatesRunner_Dataflow.groovy
index b4bb0d4af55..8a8714af26d 100644
--- a/.test-infra/jenkins/job_beam_PostCommit_Python_ValidatesRunner_Dataflow.groovy
+++ b/.test-infra/jenkins/job_beam_PostCommit_Python_ValidatesRunner_Dataflow.groovy
@@ -40,7 +40,7 @@ job('beam_PostCommit_Python_ValidatesRunner_Dataflow') {
   parameters {
     nodeParam('TEST_HOST') {
       description('select test host as either beam1, 2 or 3')
-      defaultNodes(['beam3'])
+      defaultNodes(['beam1', 'beam2', 'beam3'])
       allowedNodes(['beam1', 'beam2', 'beam3'])
       trigger('multiSelectionDisallowed')
       eligibility('IgnoreOfflineNodeEligibility')
diff --git a/.test-infra/jenkins/job_beam_PostCommit_Python_Verify.groovy b/.test-infra/jenkins/job_beam_PostCommit_Python_Verify.groovy
index 646ec59ef42..6498e39fd9d 100644
--- a/.test-infra/jenkins/job_beam_PostCommit_Python_Verify.groovy
+++ b/.test-infra/jenkins/job_beam_PostCommit_Python_Verify.groovy
@@ -41,7 +41,7 @@ job('beam_PostCommit_Python_Verify') {
   parameters {
       nodeParam('TEST_HOST') {
           description('select test host as either beam1, 2 or 3')
-          defaultNodes(['beam3'])
+          defaultNodes(['beam1', 'beam2', 'beam3'])
           allowedNodes(['beam1', 'beam2', 'beam3'])
           trigger('multiSelectionDisallowed')
           eligibility('IgnoreOfflineNodeEligibility')


 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Python postcommit always runs on beam3
> --------------------------------------
>
>                 Key: BEAM-3395
>                 URL: https://issues.apache.org/jira/browse/BEAM-3395
>             Project: Beam
>          Issue Type: Bug
>          Components: testing
>            Reporter: Udi Meiri
>            Assignee: Udi Meiri
>            Priority: Minor
>
> In https://issues.apache.org/jira/projects/BEAM/issues/BEAM-1793, there was a change
that set the list of allowed nodes and a default node. I believe that this change made postcommits
always run on beam3.
> Evidence:
> https://builds.apache.org/job/beam_PostCommit_Python_Verify/buildTimeTrend
> https://builds.apache.org/job/beam_PostCommit_Python_ValidatesRunner_Dataflow/buildTimeTrend



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message