beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <>
Subject [jira] [Commented] (BEAM-3060) Add performance tests for commonly used file-based I/O PTransforms
Date Mon, 04 Dec 2017 16:52:00 GMT


ASF GitHub Bot commented on BEAM-3060:

szewi closed pull request #4210: [BEAM-3060] Temporary fix for failing tests on dataflow runner.

This is a PR merged from a forked repository.
As GitHub hides the original diff on merge, it is displayed below for
the sake of provenance:

As this is a foreign pull request (from a fork), the diff is supplied
below (as it won't show otherwise due to GitHub magic):

diff --git a/sdks/java/io/file-based-io-tests/src/test/java/org/apache/beam/sdk/io/text/
index e9aac8001b1..5f3f5406d61 100644
--- a/sdks/java/io/file-based-io-tests/src/test/java/org/apache/beam/sdk/io/text/
+++ b/sdks/java/io/file-based-io-tests/src/test/java/org/apache/beam/sdk/io/text/
@@ -46,6 +46,7 @@
 import org.apache.beam.sdk.transforms.Combine;
 import org.apache.beam.sdk.transforms.DoFn;
 import org.apache.beam.sdk.transforms.ParDo;
+import org.apache.beam.sdk.transforms.Reshuffle;
 import org.apache.beam.sdk.transforms.Values;
 import org.apache.beam.sdk.transforms.View;
 import org.apache.beam.sdk.values.PCollection;
@@ -118,7 +119,8 @@ public void writeThenReadAll() {
         .apply("Generate sequence", GenerateSequence.from(0).to(numberOfTextLines))
         .apply("Produce text lines", ParDo.of(new DeterministicallyConstructTestTextLineFn()))
         .apply("Write content to files", write)
-        .getPerDestinationOutputFilenames().apply(Values.<String>create());
+        .getPerDestinationOutputFilenames().apply(Values.<String>create())
+        .apply(Reshuffle.<String>viaRandomKey());
     PCollection<String> consolidatedHashcode = testFilenames
         .apply("Read all files", TextIO.readAll().withCompression(AUTO))


This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:

> Add performance tests for commonly used file-based I/O PTransforms
> ------------------------------------------------------------------
>                 Key: BEAM-3060
>                 URL:
>             Project: Beam
>          Issue Type: Test
>          Components: sdk-java-core
>            Reporter: Chamikara Jayalath
>            Assignee: Szymon Nieradka
> We recently added a performance testing framework [1] that can be used to do following.
> (1) Execute Beam tests using PerfkitBenchmarker
> (2) Manage Kubernetes-based deployments of data stores.
> (3) Easily publish benchmark results. 
> I think it will be useful to add performance tests for commonly used file-based I/O PTransforms
using this framework. I suggest looking into following formats initially.
> (1) AvroIO
> (2) TextIO
> (3) Compressed text using TextIO
> (4) TFRecordIO
> It should be possibly to run these tests for various Beam runners (Direct, Dataflow,
Flink, Spark, etc.) and file-systems (GCS, local, HDFS, etc.) easily.
> In the initial version, tests can be made manually triggerable for PRs through Jenkins.
Later, we could make some of these tests run periodically and publish benchmark results (to
BigQuery) through PerfkitBenchmarker.
> [1]

This message was sent by Atlassian JIRA

View raw message