beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <>
Subject [jira] [Commented] (BEAM-413) Mean$CountSum tests for floating point equality
Date Tue, 05 Dec 2017 23:01:00 GMT


ASF GitHub Bot commented on BEAM-413:

huygaa11 opened a new pull request #4219: [BEAM-413] Created local annotation for floating
point equality warning.
   Equals method for the CountSum is used in a test that makes sure encoding and decoding
CountSum object results in an equal object. Since coderDecodeEncodeEqual method below takes
an object and does the equality check automatically, it is easier to keep the equals() function
with annotation than removing it and writing custom method instead of coderDecodeEncodeEqual.

   CoderProperties.coderDecodeEncodeEqual(coder, countSumObject);

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:

> Mean$CountSum tests for floating point equality
> -----------------------------------------------
>                 Key: BEAM-413
>                 URL:
>             Project: Beam
>          Issue Type: Bug
>          Components: sdk-java-core
>            Reporter: Scott Wegner
>            Assignee: Batkhuyag Batsaikhan
>            Priority: Minor
>              Labels: findbugs, newbie, starter
Test for floating point equality
> Applies to: [Mean$CountSum.equals|].
> This is a good starter bug. When fixing, please remove the corresponding entries from
and verify the build passes.

This message was sent by Atlassian JIRA

View raw message