Mailing-List: contact commits-help@beam.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@beam.apache.org
Date: Wed, 29 Nov 2017 14:56:00 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: commits@beam.apache.org
Message-ID: <JIRA.13120664.1511543384000.345928.1511967360060@Atlassian.JIRA>
In-Reply-To: <JIRA.13120664.1511543384000@Atlassian.JIRA>
References: <JIRA.13120664.1511543384000@Atlassian.JIRA> <JIRA.13120664.1511543384197@jira-lw-us.apache.org>
Subject: [jira] [Commented] (BEAM-3244) Flink runner does not respect
 ParDo's lifecycle on case of exceptions
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
archived-at: Wed, 29 Nov 2017 14:56:05 -0000


    [ https://issues.apache.org/jira/browse/BEAM-3244?page=3Dcom.atlassian.=
jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D16270=
891#comment-16270891 ]=20

ASF GitHub Bot commented on BEAM-3244:
--------------------------------------

aljoscha commented on a change in pull request #4174: [BEAM-3244] Ensure ex=
ecution of teardown method on Flink's DoFnOperator
URL: https://github.com/apache/beam/pull/4174#discussion_r153809786
=20
=20

 ##########
 File path: runners/flink/src/main/java/org/apache/beam/runners/flink/trans=
lation/wrappers/streaming/DoFnOperator.java
 ##########
 @@ -380,7 +386,6 @@ public void close() throws Exception {
       }
     }
     checkFinishBundleTimer.cancel(true);
=20
 Review comment:
   yes, you're right. This can also be moved to `dispose()`. =F0=9F=91=8D=
=20

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
=20
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Flink runner does not respect ParDo's lifecycle on case of exceptions
> ---------------------------------------------------------------------
>
>                 Key: BEAM-3244
>                 URL: https://issues.apache.org/jira/browse/BEAM-3244
>             Project: Beam
>          Issue Type: Bug
>          Components: runner-flink
>    Affects Versions: 2.2.0
>            Reporter: Isma=C3=ABl Mej=C3=ADa
>            Assignee: Isma=C3=ABl Mej=C3=ADa
>
> The lifecycle of the DoFn is not respected in case of exception in any of=
 the lifecycle methods after setup.


--
This message was sent by Atlassian JIRA
(v6.4.14#64029)