Mailing-List: contact commits-help@beam.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@beam.apache.org
Date: Mon, 27 Nov 2017 03:46:00 +0000 (UTC)
From: "ASF GitHub Bot (JIRA)" <jira@apache.org>
To: commits@beam.apache.org
Message-ID: <JIRA.13116232.1509864626000.321357.1511754360068@Atlassian.JIRA>
In-Reply-To: <JIRA.13116232.1509864626000@Atlassian.JIRA>
References: <JIRA.13116232.1509864626000@Atlassian.JIRA> <JIRA.13116232.1509864626288@jira-lw-us.apache.org>
Subject: [jira] [Commented] (BEAM-3143) Fix type inference in Python 3 for
 generators
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
archived-at: Mon, 27 Nov 2017 03:46:04 -0000


    [ https://issues.apache.org/jira/browse/BEAM-3143?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16266342#comment-16266342 ] 

ASF GitHub Bot commented on BEAM-3143:
--------------------------------------

luke-zhu opened a new pull request #4176: [BEAM-3143] Type Inference Compatibility with Python 3
URL: https://github.com/apache/beam/pull/4176
 
 
   Follow this checklist to help us incorporate your contribution quickly and easily:
   
    - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/projects/BEAM/issues/) filed for the change (usually before you start working on it).  Trivial changes like typos do not require a JIRA issue.  Your pull request should address just this issue, without pulling in other changes.
    - [ ] Each commit in the pull request should have a meaningful subject line and body.
    - [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue.
    - [ ] Write a pull request description that is detailed enough to understand what the pull request does, how, and why.
    - [ ] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically.
    - [ ] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
   
   ---
   Builds of Holden's work to get a type inference solution that passes precommit tests on Python 2 and type inference unit tests on Python 3.5.
   
   The disassembler code may need more changes if we aim for 3.6+ due to the byteword to quadword change. I've ported some code from CPython's lib/dis to disassembly.py This should make any future migration to 3.6+ easier.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Fix type inference in Python 3 for generators
> ---------------------------------------------
>
>                 Key: BEAM-3143
>                 URL: https://issues.apache.org/jira/browse/BEAM-3143
>             Project: Beam
>          Issue Type: Sub-task
>          Components: sdk-py-core
>            Reporter: holdenk
>


--
This message was sent by Atlassian JIRA
(v6.4.14#64029)