beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tgroh <>
Subject [GitHub] beam pull request #4105: [BEAM-2899] Fork FnDataService from runners-core
Date Thu, 09 Nov 2017 01:00:17 GMT
GitHub user tgroh opened a pull request:

    [BEAM-2899]  Fork FnDataService from runners-core

    Follow this checklist to help us incorporate your contribution quickly and easily:
     - [ ] Make sure there is a [JIRA issue](
filed for the change (usually before you start working on it).  Trivial changes like typos
do not require a JIRA issue.  Your pull request should address just this issue, without pulling
in other changes.
     - [ ] Each commit in the pull request should have a meaningful subject line and body.
     - [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`,
where you replace `BEAM-XXX` with the appropriate JIRA issue.
     - [ ] Write a pull request description that is detailed enough to understand what the
pull request does, how, and why.
     - [ ] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will
be performed on your pull request automatically.
     - [ ] If this contribution is large, please file an Apache [Individual Contributor License
    Also remove the runners-core fn package.

You can merge this pull request into a Git repository by running:

    $ git pull fork_data_service

Alternatively you can review and apply these changes as the patch at:

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4105
commit 9898a0b930ba2beb91d6c7b2b9c6093b111d8ba9
Author: Thomas Groh <>
Date:   2017-11-08T18:34:19Z

    Fork FnDataService from runners-core
    This necessitates a dependency on the Core SDK for Coder and WindowedValue.

commit 9bdcdb7ed2b57e8e430af7d8fb669edf71899df2
Author: Thomas Groh <>
Date:   2017-11-09T00:58:45Z

    Remove core-java/fn package
    This is actually unused, and available within java-fn-execution, which
    is the preferred module in which to store FnApi libraries.



View raw message