beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From echauchot <...@git.apache.org>
Subject [GitHub] beam pull request #4098: [BEAM-3118] Fix thread leaks in ElasticsearchIOTest...
Date Wed, 08 Nov 2017 15:05:03 GMT
GitHub user echauchot opened a pull request:

    https://github.com/apache/beam/pull/4098

    [BEAM-3118] Fix thread leaks in ElasticsearchIOTest.testWriteWith* when using DoFnTester

    Follow this checklist to help us incorporate your contribution quickly and easily:
    
     - [X] Make sure there is a [JIRA issue](https://issues.apache.org/jira/projects/BEAM/issues/)
filed for the change (usually before you start working on it).  Trivial changes like typos
do not require a JIRA issue.  Your pull request should address just this issue, without pulling
in other changes.
     - [X] Each commit in the pull request should have a meaningful subject line and body.
     - [X] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`,
where you replace `BEAM-XXX` with the appropriate JIRA issue.
     - [X] Write a pull request description that is detailed enough to understand what the
pull request does, how, and why.
     - [X] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will
be performed on your pull request automatically.
     - [X] If this contribution is large, please file an Apache [Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.pdf).
    
    ---
    DoFnTester is configured in CLONE_ONCE cloning behavior. So we need to explicitly call
DoFnTester.close() so that doFn.tearDown() could be called and the ES Resclient properly closed
causing the http leaked threads to be properly terminated.
    R: @jkff 

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/echauchot/beam BEAM-3118-write-tests-leak-threads

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/4098.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4098
    
----
commit fdf66f9007571c6807b345e506e8529f2e2dcec7
Author: Etienne Chauchot <echauchot@gmail.com>
Date:   2017-11-06T16:17:32Z

    [BEAM-3118] Fix thread leaks in ElasticsearchIOTest.testWriteWith* when using DoFnTester.
    
    RestClient was not properly closed because of WriteFn cloning.

commit c4472a5ad87fa25b5b435060c821d8cfdfd52850
Author: Etienne Chauchot <echauchot@gmail.com>
Date:   2017-11-08T14:32:16Z

    [BEAM-3118] Replace expectedException in ESIOTest.testWriteWithErrors to avoid interrupting
the execution flow and properly close the DoFnTester

----


---

Mime
View raw message