beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BEAM-3171) convert a join into lookup
Date Thu, 30 Nov 2017 11:21:00 GMT

    [ https://issues.apache.org/jira/browse/BEAM-3171?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16272539#comment-16272539
] 

ASF GitHub Bot commented on BEAM-3171:
--------------------------------------

xumingming commented on a change in pull request #4196: [BEAM-3171] convert a join into lookup
URL: https://github.com/apache/beam/pull/4196#discussion_r154044352
 
 

 ##########
 File path: sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/BeamSqlSeekableTable.java
 ##########
 @@ -0,0 +1,35 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.beam.sdk.extensions.sql;
+
+import java.io.Serializable;
+import java.util.List;
+import org.apache.beam.sdk.annotations.Experimental;
+import org.apache.beam.sdk.values.BeamRecord;
+
+/**
+ * A seekable table converts a JOIN operator to an inline lookup.
+ * It's triggered by {@code SELECT * FROM FACT_TABLE JOIN LOOKUP_TABLE ON ...}.
+ */
+@Experimental
+public interface BeamSqlSeekableTable extends Serializable{
 
 Review comment:
   two comments here:
   
   1. is `BeamSqlSeekableTable` part of surface api?
   2. From the naming, should `BeamSqlSeekableTable` extends `BeamSqlTable`?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> convert a join into lookup
> --------------------------
>
>                 Key: BEAM-3171
>                 URL: https://issues.apache.org/jira/browse/BEAM-3171
>             Project: Beam
>          Issue Type: New Feature
>          Components: dsl-sql
>            Reporter: Xu Mingmin
>            Assignee: Xu Mingmin
>              Labels: experimental
>
> We use BeamSQL to run streaming jobs mostly, and  add a join_as_lookup improvement(internal
branch) to cover the streaming-to-batch case(similar as [1]). I could submit a PR as experimental
if people are interested. 
> The rough solution is, if one source of join node implements {{BeamSeekableTable}} and
the other is not, then the join node is converted to a fact-lookup operation.
> Ref:
> [1] https://docs.google.com/document/d/1B-XnUwXh64lbswRieckU0BxtygSV58hysqZbpZmk03A/edit?usp=sharing

> [~xumingming] [~takidau] for any comments



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message