beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (BEAM-3153) Allow streaming processing time domain timers in Beam Python DirectRunner
Date Thu, 30 Nov 2017 21:15:00 GMT

    [ https://issues.apache.org/jira/browse/BEAM-3153?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16273447#comment-16273447
] 

ASF GitHub Bot commented on BEAM-3153:
--------------------------------------

mariapython commented on a change in pull request #4148: [BEAM-3153] Add Python processing-time
timers and clock injection
URL: https://github.com/apache/beam/pull/4148#discussion_r154203070
 
 

 ##########
 File path: sdks/python/apache_beam/runners/direct/clock.py
 ##########
 @@ -15,36 +15,35 @@
 # limitations under the License.
 #
 
-"""Clock implementations for real time processing and testing."""
+"""Clock implementations for real time processing and testing.
 
+For internal use only. No backwards compatibility guarantees.
+"""
 from __future__ import absolute_import
 
 import time
 
 
 class Clock(object):
-  """For internal use only; no backwards-compatibility guarantees."""
+  def current_time(self):
+    raise NotImplementedError()
 
-  def time(self):
-    """Returns the number of milliseconds since epoch."""
-    return int(time.time() * 1000)
+  def advance_time(self):
 
 Review comment:
   <!--thread_id:cc_153932406_t; commit:517fae9dcb749a59322ea40c7de0eb90ebf5efac; resolved:1-->
   <!--section:context-quote-->
   > **charlesccychen** wrote:
   > Please add duration argument.
   
   <!--section:body-->
   Done.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


> Allow streaming processing time domain timers in Beam Python DirectRunner
> -------------------------------------------------------------------------
>
>                 Key: BEAM-3153
>                 URL: https://issues.apache.org/jira/browse/BEAM-3153
>             Project: Beam
>          Issue Type: Bug
>          Components: sdk-py-core
>            Reporter: Charles Chen
>            Assignee: MarĂ­a GH
>
> Currently, streaming execution in the Python Beam DirectRunner only allows for watermark
domain timers and does not allow for processing time timers.  We should support processing
time timers, along with a testing framework (potentially with a fake clock) that lets us test
this behavior using the TestStream primitive.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message