beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <>
Subject [jira] [Commented] (BEAM-2524) Update Google Cloud Console URL returned by DataflowRunner to support regions.
Date Wed, 29 Nov 2017 01:27:00 GMT


ASF GitHub Bot commented on BEAM-2524:

lostluck commented on a change in pull request #4144: [BEAM-2524] Update the gcloud cancel
command to include the --region flag.

 File path: runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/util/
 @@ -214,8 +214,8 @@ public static String getGcloudCancelCommand(DataflowPipelineOptions options,
     // Assemble cancel command from optional prefix and project/job parameters.
-    return String.format("%s%s jobs --project=%s cancel %s",
-        dataflowApiOverridePrefix, GCLOUD_DATAFLOW_PREFIX, options.getProject(), jobId);
+    return String.format("%s%s jobs --project=%s cancel %s --region=%s",
 Review comment:
   I'll need to check on that. I think it can be adjacent to the project, when the command
has the --region flag (not all commands do, just most of them)

This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:

> Update Google Cloud Console URL returned by DataflowRunner to support regions.
> ------------------------------------------------------------------------------
>                 Key: BEAM-2524
>                 URL:
>             Project: Beam
>          Issue Type: Improvement
>          Components: runner-dataflow
>            Reporter: Robert Burke
>            Assignee: Robert Burke
>             Fix For: 2.2.0
>   Original Estimate: 24h
>  Remaining Estimate: 24h
> Both the Java and Python Dataflow Runners need to be updated with a regionalized form
of the Google Cloud Console URL to support multiple Dataflow Regions.
> The new URL format will be:

This message was sent by Atlassian JIRA

View raw message