beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Luke Cwik (JIRA)" <j...@apache.org>
Subject [jira] [Resolved] (BEAM-2482) CodedValueMutationDetector should use the coders structural value
Date Wed, 01 Nov 2017 17:45:00 GMT

     [ https://issues.apache.org/jira/browse/BEAM-2482?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Luke Cwik resolved BEAM-2482.
-----------------------------
       Resolution: Fixed
    Fix Version/s: 2.3.0

> CodedValueMutationDetector should use the coders structural value
> -----------------------------------------------------------------
>
>                 Key: BEAM-2482
>                 URL: https://issues.apache.org/jira/browse/BEAM-2482
>             Project: Beam
>          Issue Type: Improvement
>          Components: runner-direct
>            Reporter: Luke Cwik
>            Assignee: Innocent
>            Priority: Minor
>              Labels: newbie, starter
>             Fix For: 2.3.0
>
>
> Currently the CodedValueMutationDetector[1] checks to see if the objects are Java equals
and then compares whether the bytes are equal. Instead of relying on the bytes, we should
rely on the coders structural value explicitly[2]. This allows for a coder to provide a fast
path equality check with the default still comparing byte array representations.
> 1: https://github.com/apache/beam/blob/eae0d05bd7c088accd927dcfe3e511efbb11c9fd/sdks/java/core/src/main/java/org/apache/beam/sdk/util/MutationDetectors.java
> 2: https://github.com/apache/beam/blob/01b3f87f977d44eac23eb5488074bbc638858a9d/sdks/java/core/src/main/java/org/apache/beam/sdk/coders/Coder.java#L252



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message