beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <>
Subject [jira] [Commented] (BEAM-867) Support set/delete of timers by ID in Flink runner
Date Mon, 13 Nov 2017 09:52:00 GMT


ASF GitHub Bot commented on BEAM-867:

GitHub user johanhaleby opened a pull request:

    [BEAM-867] Add schema update options to BigQueryIO

    Follow this checklist to help us incorporate your contribution quickly and easily:
     - [x] Make sure there is a [JIRA issue](
filed for the change (usually before you start working on it).  Trivial changes like typos
do not require a JIRA issue.  Your pull request should address just this issue, without pulling
in other changes.
     - [x] Each commit in the pull request should have a meaningful subject line and body.
     - [x] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`,
where you replace `BEAM-XXX` with the appropriate JIRA issue.
     - [x] Write a pull request description that is detailed enough to understand what the
pull request does, how, and why.
     - [ ] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will
be performed on your pull request automatically.
     - [ ] If this contribution is large, please file an Apache [Individual Contributor License
    This is a first attempt at solving [BEAM-876](
This should work for batch inserts but I haven't found a way to implement it for streaming
    Note that I was not able to successfully run `mvn clean verify` even before I started
with this PR. 
    Also I've not added any tests since I'm a bit uncertain on how to do this. Please advice.

You can merge this pull request into a Git repository by running:

    $ git pull master

Alternatively you can review and apply these changes as the patch at:

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4119
commit f8c91bcc6423d7c1ca8d6e6904af5bb9729cc281
Author: Johan Haleby <>
Date:   2017-11-13T09:44:07Z

    [BEAM-867] Add schema update options to BigQueryIO


> Support set/delete of timers by ID in Flink runner
> --------------------------------------------------
>                 Key: BEAM-867
>                 URL:
>             Project: Beam
>          Issue Type: New Feature
>          Components: runner-flink
>            Reporter: Kenneth Knowles
>            Assignee: Aljoscha Krettek
> This is a prerequisite for full support of BEAM-27, and related to BEAM-35.
> My current understanding is that this might be actually removed from Flink itself, and
needs implementation in terms of state. It might be reasonable to just remove deletion from
Beam; it is just a nice-to-have for user experience IMO, and perhaps a performance help for
certain runners.
> (Since I am filing individual tickets for each runner, generalized discussion should
probably be on the dev list directly on or BEAM-35)

This message was sent by Atlassian JIRA

View raw message