Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id DEA2B200D15 for ; Thu, 5 Oct 2017 11:47:51 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id DD2A81609E1; Thu, 5 Oct 2017 09:47:51 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 2F9E61609DA for ; Thu, 5 Oct 2017 11:47:51 +0200 (CEST) Received: (qmail 23734 invoked by uid 500); 5 Oct 2017 09:47:50 -0000 Mailing-List: contact commits-help@beam.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@beam.apache.org Delivered-To: mailing list commits@beam.apache.org Received: (qmail 23724 invoked by uid 99); 5 Oct 2017 09:47:50 -0000 Received: from git1-us-west.apache.org (HELO git1-us-west.apache.org) (140.211.11.23) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 05 Oct 2017 09:47:50 +0000 Received: by git1-us-west.apache.org (ASF Mail Server at git1-us-west.apache.org, from userid 33) id 5B29CF3310; Thu, 5 Oct 2017 09:47:48 +0000 (UTC) From: echauchot To: commits@beam.apache.org Reply-To: commits@beam.apache.org Message-ID: Subject: [GitHub] beam pull request #3948: [BEAM-3019] Make AvroIOReadTransformTest more gener... Content-Type: text/plain Date: Thu, 5 Oct 2017 09:47:48 +0000 (UTC) archived-at: Thu, 05 Oct 2017 09:47:52 -0000 GitHub user echauchot opened a pull request: https://github.com/apache/beam/pull/3948 [BEAM-3019] Make AvroIOReadTransformTest more generic Follow this checklist to help us incorporate your contribution quickly and easily: - [X] Make sure there is a [JIRA issue](https://issues.apache.org/jira/projects/BEAM/issues/) filed for the change (usually before you start working on it). Trivial changes like typos do not require a JIRA issue. Your pull request should address just this issue, without pulling in other changes. - [X] Each commit in the pull request should have a meaningful subject line and body. - [X] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA issue. - [X] Write a pull request description that is detailed enough to understand what the pull request does, how, and why. - [X] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will be performed on your pull request automatically. - [X] If this contribution is large, please file an Apache [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.pdf). --- - Make runTestWrite() more generic to be able to use GenericRecord[] as input for writeGenericRecords test in place of AvroGeneratedUser - Make readAvroFile() generic to be able to read GenericRecords using GenericDatumReader for writeGenericRecords test R: @jkff You can merge this pull request into a Git repository by running: $ git pull https://github.com/echauchot/beam AvroIO_improve_AvroIOWriteTransformTest Alternatively you can review and apply these changes as the patch at: https://github.com/apache/beam/pull/3948.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #3948 ---- commit 133d095c0df7f9c0b48aa7dde96512c09e3f1881 Author: Etienne Chauchot Date: 2017-10-05T09:45:12Z [BEAM-3019] Make AvroIOReadTransformTest more generic make runTestWrite() more generic to be able to use GenericRecord[] as input for writeGenericRecords test in place of AvroGeneratedUser make readAvroFile() generic to be able to read GenericRecords using GenericDatumReader for writeGenericRecords test ---- ---