Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 858E8200D20 for ; Tue, 17 Oct 2017 22:43:04 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 84320160BEA; Tue, 17 Oct 2017 20:43:04 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id D47C21609D9 for ; Tue, 17 Oct 2017 22:43:03 +0200 (CEST) Received: (qmail 15110 invoked by uid 500); 17 Oct 2017 20:43:03 -0000 Mailing-List: contact commits-help@beam.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@beam.apache.org Delivered-To: mailing list commits@beam.apache.org Received: (qmail 15100 invoked by uid 99); 17 Oct 2017 20:43:03 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 17 Oct 2017 20:43:03 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 580CACEBCE for ; Tue, 17 Oct 2017 20:43:02 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -99.202 X-Spam-Level: X-Spam-Status: No, score=-99.202 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id u1GQvYT6Uztb for ; Tue, 17 Oct 2017 20:43:01 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with ESMTP id 6E9CA5FBC0 for ; Tue, 17 Oct 2017 20:43:01 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id B454AE0EF0 for ; Tue, 17 Oct 2017 20:43:00 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 288092438E for ; Tue, 17 Oct 2017 20:43:00 +0000 (UTC) Date: Tue, 17 Oct 2017 20:43:00 +0000 (UTC) From: "Vilhelm von Ehrenheim (JIRA)" To: commits@beam.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (BEAM-3070) Add support for windowed filenames in Python SDK MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Tue, 17 Oct 2017 20:43:04 -0000 [ https://issues.apache.org/jira/browse/BEAM-3070?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16208296#comment-16208296 ] Vilhelm von Ehrenheim commented on BEAM-3070: --------------------------------------------- [~altay] Just reported this. I couldn't find any ticket addressing this issue. If duplicated let me know. If not I would be happy to start contributing on this if you think it is suitable. > Add support for windowed filenames in Python SDK > ------------------------------------------------ > > Key: BEAM-3070 > URL: https://issues.apache.org/jira/browse/BEAM-3070 > Project: Beam > Issue Type: Improvement > Components: sdk-py-core > Reporter: Vilhelm von Ehrenheim > Assignee: Ahmet Altay > > The Python SDK's FilebasedSink does not support windowed filenames. Currently the only filename template available is based on shards. > The Java SDK has this feature in the `FilenamePolicy.windowedFilename()`. The python SDk only has a somewhat more simple implementation using a text template and `FileBasedSink._template_to_format()` which does not support windows. -- This message was sent by Atlassian JIRA (v6.4.14#64029)