beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From tgroh <...@git.apache.org>
Subject [GitHub] beam pull request #4044: Do not relocate generated Model Classes
Date Thu, 26 Oct 2017 22:01:48 GMT
GitHub user tgroh opened a pull request:

    https://github.com/apache/beam/pull/4044

    Do not relocate generated Model Classes

    Follow this checklist to help us incorporate your contribution quickly and easily:
    
     - [ ] Make sure there is a [JIRA issue](https://issues.apache.org/jira/projects/BEAM/issues/)
filed for the change (usually before you start working on it).  Trivial changes like typos
do not require a JIRA issue.  Your pull request should address just this issue, without pulling
in other changes.
     - [ ] Each commit in the pull request should have a meaningful subject line and body.
     - [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`,
where you replace `BEAM-XXX` with the appropriate JIRA issue.
     - [ ] Write a pull request description that is detailed enough to understand what the
pull request does, how, and why.
     - [ ] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will
be performed on your pull request automatically.
     - [ ] If this contribution is large, please file an Apache [Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.pdf).
    
    ---
    Doing so with this pattern breaks the clients, as the shade plugin will
    rewrite the gRPC method name as well, which servers do not implement.
    All calls will then be broken.
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tgroh/beam do_not_shade_model_in_harness

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/4044.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4044
    
----
commit 2c1e4e1480c47ffbfd45688edc1213cd9ce961d5
Author: Thomas Groh <tgroh@google.com>
Date:   2017-10-26T22:00:12Z

    Do not relocate generated Model Classes
    
    Doing so with this pattern breaks the clients, as the shade plugin will
    rewrite the gRPC method name as well, which servers do not implement.
    All calls will then be broken.

----


---

Mime
View raw message