beam-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From youngoli <...@git.apache.org>
Subject [GitHub] beam pull request #4035: [BEAM-2530] Updating to AutoValue 1.5.1 to support ...
Date Wed, 25 Oct 2017 01:06:20 GMT
GitHub user youngoli opened a pull request:

    https://github.com/apache/beam/pull/4035

    [BEAM-2530] Updating to AutoValue 1.5.1 to support Java 9.

    Follow this checklist to help us incorporate your contribution quickly and easily:
    
     - [x] Make sure there is a [JIRA issue](https://issues.apache.org/jira/projects/BEAM/issues/)
filed for the change (usually before you start working on it).  Trivial changes like typos
do not require a JIRA issue.  Your pull request should address just this issue, without pulling
in other changes.
     - [x] Each commit in the pull request should have a meaningful subject line and body.
     - [x] Format the pull request title like `[BEAM-XXX] Fixes bug in ApproximateQuantiles`,
where you replace `BEAM-XXX` with the appropriate JIRA issue.
     - [x] Write a pull request description that is detailed enough to understand what the
pull request does, how, and why.
     - [x] Run `mvn clean verify` to make sure basic checks pass. A more thorough check will
be performed on your pull request automatically.
     - [x] If this contribution is large, please file an Apache [Individual Contributor License
Agreement](https://www.apache.org/licenses/icla.pdf).
    
    ---
    
    A fix to a Java 9 build error caused by AutoValue was fixed in version 1.5.1. I updated
the maven project to use 1.5.1, which meant excluding it from the ban on non-Java 7 dependencies.
    
    I assume this change breaks Java 7 support, but I couldn't figure out how to test that
to confirm my assumption.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/youngoli/beam JDK9

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/beam/pull/4035.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #4035
    
----
commit 34524609b9b2ac38d3ccc889c254424a074e4699
Author: Daniel Oliveira <daniel.o.programmer@gmail.com>
Date:   2017-10-24T21:34:38Z

    Getting AutoValue 1.5.1 working in Beam.

----


---

Mime
View raw message